Skip to content

v3.4.1 #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020
Merged

v3.4.1 #1766

merged 1 commit into from
Jun 4, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jun 4, 2020

VS Code v1.45.1

Bug Fixes

  • Hopefully this one fixes autoupdates from 3.2.0 once and for all.

  • The config file's extension-dir and data-dir parameters are now properly obeyed user-data-dir, extensions-dir in config file still doesn't work #1750

    • This was supposed to be fixed in the last release but because of a subtle bug it turned out it was printing the correct directories but not actually using them.
    • It should now use extension-dir and data-dir as set in the config file
  • We do not bundle any dynamic libraries in releases anymore issues including libstdc++ (or how to get eaten by a grue) #1738

    • It was causing bizarre issues for users and we couldn't make it work perfectly.
    • On Linux we now compile on CentOS 7 so that the minimum glibc version is v2.17 and glibcxx is v3.4.18
    • On macOS we now pull in a fully static release of node.
  • Using the deprecated root code-server symlink now warns on usage that it will be removed in the next few weeks.

    • The entry script now also handles recursive symlinks correctly.
  • globalStorageHome is now created on startup Code server missing globalStorage folder #1693 so that extensions that rely on it being there should work now

@nhooyr nhooyr merged commit d3773c1 into master Jun 4, 2020
@nhooyr nhooyr deleted the v3.4.1 branch June 4, 2020 16:30
@GeorgeDavis-TM
Copy link

Still seeing issues with v3.4.1.

ubuntu@ip-172-31-70-10:~$ code-server -v
info Using config file ~/.config/code-server/config.yaml
3.4.1 48f7c2724827e526eeaa6c2c151c520f48a61259

config.yaml looks like this

bind-addr: 0.0.0.0:8080
auth: password
password: "346y3vh2"
cert: false
extension-dir: ~/vscode/ext
data-dir: ~/vscode/user-data

Error message reads
error reading /home/ubuntu/.config/code-server/config.yaml: Unknown option --extension-dir=~/vscode/ext
error reading /home/ubuntu/.config/code-server/config.yaml: Unknown option --data-dir=~/vscode/user-data

@nhooyr Any comments? Thank you.

@code-asher
Copy link
Member

code-asher commented Aug 19, 2020

@GeorgeDavis-TM Those options are a little bit off, sorry about that. Here's the relevant output from --help:

      --user-data-dir       Path to the user data directory.
      --extensions-dir      Path to the extensions directory.

@nhooyr nhooyr restored the v3.4.1 branch August 25, 2020 19:10
@nhooyr nhooyr deleted the v3.4.1 branch January 7, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants