Skip to content

Add auto install script #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
May 28, 2020
Merged

Add auto install script #1701

merged 27 commits into from
May 28, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented May 20, 2020

No description provided.

@nhooyr nhooyr force-pushed the auto-install branch 3 times, most recently from c2230c4 to 7e50de2 Compare May 20, 2020 13:11
@nhooyr
Copy link
Contributor Author

nhooyr commented May 20, 2020

~/src/cdr/code-server:auto-install$ ./install.sh --help
./install.sh [-d] [-s] [-p <static-install-prefix>]

Installs code-server on any macOS or Linux system.

If ran on Ubuntu, Debian or Raspbian then the GitHub releases v3.3.1
deb package will be fetched and installed.

If ran on Fedora, CentOS, RHEL or openSUSE then the GitHub releases v3.3.1
rpm package will be fetched and installed.

If ran on macOS and Homebrew is installed then the Homebrew code-server
package will be installed. However, if Homebrew is not installed then
v3.3.1 of the macOS static archive on GitHub releases will be installed
into /usr/local/lib/code-server-3.3.1.

If ran on Arch Linux, then the code-server AUR package will be installed.

If ran on an unsupported architecture the npm package will be installed
with yarn or npm. Only amd64 and arm64 are currently supported.

If ran on any other Linux distro, v3.3.1 of the linux static archive on GitHub
releases will be installed into /usr/local/lib/code-server-3.3.1.

  -d Enables a dry run where where the steps that would have taken place
     are printed but do not actually execute.

  -s Forces the installation of a static release into /usr/local/lib/code-server-3.3.1
     Set the -p flag to change the installation prefix from /usr/local/lib

  -p Sets the installation prefix for a static release install.

@nhooyr nhooyr requested review from code-asher and kylecarbs May 20, 2020 13:16
@nhooyr nhooyr force-pushed the auto-install branch 2 times, most recently from b6684bd to a3033bc Compare May 20, 2020 13:18
@nhooyr
Copy link
Contributor Author

nhooyr commented May 20, 2020

Need to add to README.md and guide.md

In the next release we'll add installation over SSH support and then deprecate sshcode.

@nhooyr nhooyr force-pushed the auto-install branch 2 times, most recently from 18164f7 to 4e8b1b8 Compare May 20, 2020 13:21
@nhooyr nhooyr marked this pull request as ready for review May 20, 2020 13:29
@nhooyr nhooyr requested a review from coadler May 20, 2020 15:47
@nhooyr
Copy link
Contributor Author

nhooyr commented May 20, 2020

  • I think it'd be good to switch to long style flags and remove getopts.

@nhooyr
Copy link
Contributor Author

nhooyr commented May 20, 2020

  • Also good idea to remove the hard coded version and always fetch latest in case people download and store the script.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dope. Love the dry run.

@code-asher
Copy link
Member

Agreed about the long option names, those are my preference in general. Fetching the latest version also seems like a good idea.

@nhooyr
Copy link
Contributor Author

nhooyr commented May 21, 2020

And check for libc and libcxx #1706

@nhooyr nhooyr requested a review from code-asher May 21, 2020 19:34
@nhooyr
Copy link
Contributor Author

nhooyr commented May 21, 2020

@code-asher Please re-review the new changes.

Last thing I need to take care of is #1706

@nhooyr
Copy link
Contributor Author

nhooyr commented May 21, 2020

Now that we know we have compat for glibc v2.17 I don't think it's worth the complexity in the install script to detect for anything below that since that's already 8 years old. And there is no other dependency anymore.

More clear as discussed in PR.
@nhooyr nhooyr merged commit 80bcfd9 into master May 28, 2020
@nhooyr nhooyr deleted the auto-install branch May 28, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants