Skip to content

Workaround for GH Actions stripping permissions #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/issue_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Please ensure you cannot reproduce on VS Code before filing.
Please fill in the issue template or we will close your issue!
-->

- Web Browser:
- Web Browser:
- Local OS:
- Remote OS:
- `code-server --version`:
- `code-server --version`:
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
uses: actions/upload-artifact@v2
with:
name: npm-package
path: ./release
path: ./release-npm-package

linux-amd64:
needs: release
Expand All @@ -53,7 +53,7 @@ jobs:
uses: actions/download-artifact@v2
with:
name: npm-package
path: ./release
path: ./release-npm-package
- name: Run ./ci/steps/release-static.sh
uses: ./ci/container
with:
Expand All @@ -73,7 +73,7 @@ jobs:
uses: actions/download-artifact@v2
with:
name: npm-package
path: ./release
path: ./release-npm-package
- name: Run ./ci/steps/release-static.sh
uses: ./ci/container/arm64
with:
Expand All @@ -93,7 +93,7 @@ jobs:
uses: actions/download-artifact@v2
with:
name: npm-package
path: ./release
path: ./release-npm-package
- run: brew unlink node@12
- run: brew install node
- run: ./ci/steps/release-static.sh
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
dist*
out*
release/
release-npm-package/
release-static/
release-packages/
release-gcp/
Expand Down
4 changes: 2 additions & 2 deletions ci/steps/publish-npm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ main() {
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
fi

download_artifact npm-package ./release
download_artifact npm-package ./release-npm-package
# https://github.com/actions/upload-artifact/issues/38
chmod +x $(grep -rl '^#!/.*' release)
tar -xzf release-npm-package/package.tar.gz
yarn publish --non-interactive release
}

Expand Down
2 changes: 1 addition & 1 deletion ci/steps/release-static.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ main() {
cd "$(dirname "$0")/../.."

# https://github.com/actions/upload-artifact/issues/38
chmod +x $(grep -rl '^#!/.*' release)
tar -xzf release-npm-package/package.tar.gz

yarn release:static
yarn test:static-release
Expand Down
4 changes: 4 additions & 0 deletions ci/steps/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ main() {
yarn build
yarn build:vscode
yarn release

# https://github.com/actions/upload-artifact/issues/38
mkdir -p release-npm-package
tar -czf release-npm-package/package.tar.gz release
}

main "$@"