-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Automate draft release #1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate draft release #1623
Conversation
ebc9778
to
98a168d
Compare
1. Run `yarn release:github-draft` to create a GitHub draft release from the template with | ||
the updated version. | ||
1. Summarize the major changes in the release notes and link to the relevant issues. | ||
1. Wait for the artifacts in step 2 to build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we number these incrementally instead of just with 1
? Normally I don't pay much attention but since we called out step 2 I was trying to count up in my head and got lost a couple times lol especially since Github is rendering a gap after 2 for some reason and I kept thinking it was a separate paragraph. I always read the readmes raw so maybe that's just a me problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually in markdown you don't want to number them to avoid forgetting updates since when it renders it's immediately there but I agree it is nice when looking at the raw markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I see no gap after 2, that's weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must have something to do with the specific screen size I have my browser at. My editor automatically updates the numbers so I was hoping there was something similar for yours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goland aint as cool as emacs :(
--draft "${assets[@]}" "v$(pkg_json_version)" << EOF | ||
v$(pkg_json_version) | ||
|
||
VS Code v$(vscode_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍
No description provided.