Back up old directory when updating #1486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
approved these changes
Apr 2, 2020
| @@ -696,10 +696,6 @@ index 0000000000..96fbd4b0bb | |||
| + } | |||
| + | |||
| + const json = await response.json(); | |||
| + if (!json.isLatest) { | |||
There was a problem hiding this comment.
Wouldn't this cause no errors to be reported if an update fails?
There was a problem hiding this comment.
The response will only be a 200 if the update succeeded so it should already have bailed out on the line above. The problem with this line is that isLatest was always false since the currently running code was still the old version.
Although, that means I should log the status text and not just "unexpected response". Will do that right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the old directory with a timestamp before moving the new directory into place.
Also has a minor fix for a notification saying the update failed when it didn't (
isLatestwon't be true since that version is still technically the older version).
Fixes #1483 .