Add support for Kubernetes #146
Conversation
stevesloka
requested review from
code-asher,
kylecarbs and
nhooyr
as code owners
|
This looks awesome! I wonder if it could be improved by possibly integrating or using parts of our current Dockerfile as we currently do some building? |
|
@NGTmeaty Sounds good! I just updated to use the example Dockerfile. I should probably add some docs to this as well. Let me see if I can pull those together so it's more clear to folks. |
|
Awesome! +1 |
|
It could be nice to have an official helm chart. |
|
Please do not rely on EBS only, make it vendor agnostic |
|
It doesn't, just an example. You could reference any storage class and it would work. |
|
I could integrate kustomize to allow for customization. Could pick some clouds and show examples (e.g. AWS, GCP, Azure). What would you suggest? |
|
@stevesloka since its an example, might as well use default storage class for PVC or |
deployment/Dockerfile
Outdated
| # directly which should be fast as it is slow because it populates its own cache every time. | ||
| RUN yarn && yarn task build:server:binary | ||
|
|
||
| # Use golang base dev for go development tooling |
There was a problem hiding this comment.
Not sure we should change the base image
There was a problem hiding this comment.
I'll leave it generic. My intent was to show how to have bootstrapped images. Having to install deps is not great, but doesn't make sense at this point in time.
There was a problem hiding this comment.
I like the idea of extending it.
We could include an example of something like:
FROM codercom/code-server
RUN apt-get install mysql -y
...
There was a problem hiding this comment.
Any desire to move it to 1804. LTS for the base instead of 18.10 ? Generally prefer to build docker images on things that have longer support.
stevesloka
changed the title
|
I think the ingress controller and TLS should not be part of this. Depending on the cluster setup, those are unwanted extras in most cases. |
stevesloka
changed the title
|
I just dropped all the ingress and cert-manager stuff. I left the AWS reference, can also delete that, but might help someone in that environment. I didn't integrate local pvcs since you need to turn on a feature flag to enable and probably wouldn't work in most environments. |
example which persists data to a Persistent Volume / Claim. Signed-off-by: Steve Sloka <[email protected]>
|
Is this ready to go? Happy to merge this in. |
|
@nhooyr I can add some docs on a follow-up PR. |
|
Awesome, sounds good man. |
|
@kylecarbs can you disable the signed commits requirement? |
#146) example which persists data to a Persistent Volume / Claim. Signed-off-by: Steve Sloka <[email protected]>
Describe in detail the problem you had and how this PR fixes it
Fixes #60 by adding support for Kubernetes. This deploys code-server, Contour for ingress controller, and Cert Manager for Let's Encrypt certificates, with persistent storage with AWS EBS volumes. Also, I left the Dockerfile I used for golang development. If there's a public push of this somewhere it would be great to document how you can create base images with the right tooling up front.
This is also somewhat opiononated in that it's using AWS EBS volumes, but can be adapted for many use cases. I wasn't sure how that might get organized within the repo.
Signed-off-by: Steve Sloka [email protected]
Is there an open issue you can link to?
#60
// cc @jbeda