Skip to content

Updates manifest.json #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Updates manifest.json #1225

merged 1 commit into from
Feb 4, 2020

Conversation

TheHllm
Copy link
Contributor

@TheHllm TheHllm commented Dec 14, 2019

Improves usability by making use of fullscreen when installed as pwa.

Improves usability by making use of fullscreen when installed as pwa.
@sr229
Copy link
Contributor

sr229 commented Dec 16, 2019

How does this changes anything? I think it's fine PWA-wise in standalone mode

@TheHllm
Copy link
Contributor Author

TheHllm commented Dec 16, 2019

It makes it use "fullscreen" aka hides the url bar (on mobile browsers e.g. on a tablet) wich is so much better for use on the go.

Allthough google says that standalone hides the url bar it dose not.

@code-asher code-asher merged commit c7127cb into coder:master Feb 4, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Feb 4, 2020

@code-asher standalone should work fine. This is a bug in the browsers, I'm going to revert.

@code-asher
Copy link
Member

code-asher commented Feb 10, 2020 via email

@nhooyr
Copy link
Contributor

nhooyr commented Feb 10, 2020

The original user mentioned the URL bar not being hidden.

The status bar should be shown imo as that's what normal apps do.

@orditeck
Copy link

I don't know if my issue could be related to this but since 2.1698-vsc1.41.1, I can't create multiple "shortcuts" from the same base URL in Chrome.

I was creating one shortcut per project, for example:

Now it always override the latest shortcut I made.

Before 2.1698, CrAppModeShortcutID was always different = multiple shortcuts possible.
After 2.1698, CrAppModeShortcutID is always the same = multiple shortcuts doesn't seem possible.

@nhooyr
Copy link
Contributor

nhooyr commented Feb 11, 2020

I believe your problem is #1132

@nhooyr
Copy link
Contributor

nhooyr commented Feb 11, 2020

Oh, nvm, that's interesting. I'm not sure what's going on. Can you file an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants