-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Updates manifest.json #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates manifest.json #1225
Conversation
Improves usability by making use of fullscreen when installed as pwa.
How does this changes anything? I think it's fine PWA-wise in |
It makes it use "fullscreen" aka hides the url bar (on mobile browsers e.g. on a tablet) wich is so much better for use on the go. Allthough google says that |
@code-asher standalone should work fine. This is a bug in the browsers, I'm going to revert. |
Yeah it does work but fullscreen also hides the status bar which felt
like a more immersive editing experience to me. Is there an advantage to
having the status bar show persistently while using code-server?
|
The original user mentioned the URL bar not being hidden. The status bar should be shown imo as that's what normal apps do. |
I don't know if my issue could be related to this but since I was creating one shortcut per project, for example:
Now it always override the latest shortcut I made. Before |
I believe your problem is #1132 |
Oh, nvm, that's interesting. I'm not sure what's going on. Can you file an issue? |
Improves usability by making use of fullscreen when installed as pwa.