Skip to content

Add PWA icon back to repo; add link tag for iOS #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2019
Merged

Add PWA icon back to repo; add link tag for iOS #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c39dff
Merge pull request #1 from cdr/master
admvx Sep 16, 2019
7954a8d
Merge pull request #2 from cdr/master
admvx Oct 6, 2019
9c9133d
Add missing PWA icon
admvx Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/vscode.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,10 @@ index 3ae24454cb..d637d02855 100644
// Do nothing. If we can't read the file we have no
// language pack config.
diff --git a/src/vs/code/browser/workbench/workbench.html b/src/vs/code/browser/workbench/workbench.html
index 44f67f0a0b..00fc1deea8 100644
index 44f67f0a0b..50d29b1e87 100644
--- a/src/vs/code/browser/workbench/workbench.html
+++ b/src/vs/code/browser/workbench/workbench.html
@@ -18,10 +18,11 @@
@@ -18,10 +18,12 @@

<!-- Workarounds/Hacks (remote user data uri) -->
<meta id="vscode-remote-user-data-uri" data-settings="{{REMOTE_USER_DATA_URI}}">
Expand All @@ -160,6 +160,7 @@ index 44f67f0a0b..00fc1deea8 100644
- <link rel="manifest" href="/manifest.json">
+ <link rel="icon" href="./favicon.ico" type="image/x-icon" />
+ <link rel="manifest" href="./manifest.json">
+ <link rel="apple-touch-icon" href="./static/out/vs/server/src/media/code-server.png" />
<link data-name="vs/workbench/workbench.web.api" rel="stylesheet" href="./static/out/vs/workbench/workbench.web.api.css">
</head>

Expand Down
1 change: 1 addition & 0 deletions src/login/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<title>Authenticate: code-server</title>
<link rel="icon" href="./favicon.ico" type="image/x-icon" />
<link rel="manifest" href="./manifest.json">
<link rel="apple-touch-icon" href="./static/out/vs/server/src/media/code-server.png" />
<link href="./static/out/vs/server/src/media/login.css" rel="stylesheet">
</head>
<body>
Expand Down
Binary file added src/media/code-server.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions src/media/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"background-color": "#fff",
"description": "Run VS Code on a remote server.",
"icons": [{
"src": "static/code-server.png",
"sizes": "128x128",
"src": "./static/out/vs/server/src/media/code-server.png",
"sizes": "384x384",
"type": "image/png"
}]
}