[do not merge] Prepare code-server for ARM distribution #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same PR but with some fixes for v2. Co-Authored-by: nwtnsqrd <[email protected]> Signed-off-by: Ayane Satomi <[email protected]>
Signed-off-by: Ayane Satomi <[email protected]>
they will be seperate images from now on. Signed-off-by: Ayane Satomi <[email protected]>
we might be doing something really bad by not putting it on the same rules as Alpine ARM Signed-off-by: Ayane Satomi <[email protected]>
| @@ -9,20 +9,27 @@ function docker-build() { | |||
| local minify="${MINIFY:-}" | |||
| if [[ "${target}" == "linux" ]] ; then | |||
| image="codercom/nbin-centos" | |||
| fi | |||
| fi | |||
| @@ -81,4 +92,4 @@ function main() { | |||
| fi | |||
| } | |||
|
|
|||
| main "$@" | |||
| main "$@" | |||
|
Closing in favor of new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the requests over in GH-35, we'll be doing ARM distributions by leveraging the existing CI we have.
Do not merge until coder/nbin#23 is finished.