-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Docker issues #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Docker issues #104
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
4f0dbd4
make docker build working with after a fresh checkout
f1ddb86
upgrade lock file
c0c7de8
update .dockerignore file
b62306e
fix typo
3396cff
add more to the .dockerignore
ec2518a
add cross-env to vscode bootstrap-fork generator
7e44a39
docker additions
0c442f2
merge back codercom
3128602
remove todo
4f5e9ab
add better comment for a workaround
c8f3aa5
add sequential build to docker
035e434
remove git modules workaround
f1dc057
merge back master
bbf610d
node version downgrade to be compatible with nexe
994d5fd
restore yarn.lock
3f6aa4c
restore package.json
b935418
restore another yarn.lock
b093abd
other yarn.lock
a9b825b
restore last yarn.lock
a4f9e53
merge with the original branch
5ba803f
Merge branch 'master' of https://github.com/codercom/code-server into…
9982968
merge master in
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,47 @@ | ||
FROM node:8.9.3 | ||
FROM node:8.15.1 | ||
|
||
# Install VS Code's deps. These are the only two it seems we need. | ||
RUN apt-get update && apt-get install -y \ | ||
libxkbfile-dev \ | ||
libsecret-1-dev | ||
|
||
# Ensure latest yarn. | ||
RUN npm install -g [email protected] | ||
|
||
WORKDIR /src | ||
COPY . . | ||
|
||
# In the future, we can use https://github.com/yarnpkg/rfcs/pull/53 to make yarn use the node_modules | ||
# directly which should be fast as it is slow because it populates its own cache every time. | ||
RUN yarn && yarn task build:server:binary | ||
# This takes ages and always dies in the end. :( | ||
# RUN yarn --frozen-lockfile && yarn task build:server:binary | ||
|
||
|
||
# Make the debugging easier - and the rebuilds faster | ||
# and our life happier lets break up the build to sequential parts | ||
RUN yarn --frozen-lockfile | ||
|
||
RUN yarn task vscode:install | ||
RUN yarn task build:copy-vscode | ||
RUN yarn task build:web | ||
RUN yarn task build:bootstrap-fork | ||
RUN yarn task build:default-extensions | ||
RUN yarn task build:server:bundle | ||
RUN yarn task build:app:browser | ||
RUN yarn task build:server:binary:package | ||
zerdos marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# We deploy with ubuntu so that devs have a familiar environemnt. | ||
FROM ubuntu:18.10 | ||
WORKDIR /root/project | ||
|
||
COPY --from=0 /src/packages/server/cli-linux-x64 /usr/local/bin/code-server | ||
|
||
EXPOSE 8443 | ||
|
||
RUN apt-get update && apt-get install -y \ | ||
openssl \ | ||
net-tools | ||
|
||
RUN apt-get install -y locales && \ | ||
locale-gen en_US.UTF-8 | ||
|
||
# We unfortunately cannot use update-locale because docker will not use the env variables | ||
# configured in /etc/default/locale so we need to set it manually. | ||
ENV LANG=en_US.UTF-8 | ||
|
||
# Unfortunately `.` does not work with code-server. | ||
CMD code-server $PWD |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.15.1 will not build as nexe does not support it.
https://github.com/nexe/nexe/releases