Docker issues #104
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| Dockerfile | ||
| node_modules | ||
| */node_modules | ||
| */*/node_modules | ||
| */*/*/node_modules | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ RUN npm install -g yarn | |
| # directly which should be faster. | ||
| WORKDIR /src | ||
| COPY . . | ||
| RUN yarn --forzen-lockfile | ||
|
There was a problem hiding this comment. This should be |
||
| RUN yarn task build:server:binary | ||
|
|
||
| # We deploy with ubuntu so that devs have a familiar environemnt. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -224,7 +224,7 @@ const ensureCloned = register("vscode:clone", async (runner) => { | |
| } | ||
|
|
||
| runner.cwd = vscodePath; | ||
| const checkout = await runner.execute("git", ["checkout", "tags/1.31.1"]); //TODO: this tag should come from a parameter | ||
| if (checkout.exitCode !== 0) { | ||
| throw new Error(`Failed to checkout: ${checkout.stderr}`); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,8 +6,8 @@ | |
| "description": "Run VS Code remotely.", | ||
| "scripts": { | ||
| "build:rules": "cd ./rules && tsc -p .", | ||
| "packages:install": "cd ./packages && yarn --frozen-lockfile", | ||
| "postinstall": "npm-run-all packages:install build:rules", | ||
|
There was a problem hiding this comment. I want a rationale why the parallel flag have to be removed. |
||
| "start": "cd ./packages/server && yarn start", | ||
| "task": "ts-node -r tsconfig-paths/register build/tasks.ts", | ||
| "test": "cd ./packages && yarn test" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,12 @@ | |
| "name": "@coder/app-common", | ||
| "main": "src/app.ts", | ||
| "dependencies": { | ||
| "material-components-web": "^0.44.1", | ||
| "react": "^16.8.4", | ||
| "react-dom": "^16.8.4" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/react": "^16.8.7", | ||
| "@types/react-dom": "^16.8.2" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ const doInstall = (pkg: string, path: string): Promise<void> => { | |
| logger.info(`Installing "${pkg}" dependencies...`); | ||
|
|
||
| return new Promise((resolve): void => { | ||
| exec("yarn --frozen-lockfile --network-concurrency 1", { | ||
| cwd: path, | ||
| maxBuffer: 1024 * 1024 * 10, | ||
| }, (error, stdout, stderr) => { | ||
|
|
@@ -41,7 +41,7 @@ const handlePackages = async (dir: string): Promise<void> => { | |
| const pkgDir = join(dir, pkg); | ||
| const pkgJsonPath = join(pkgDir, "package.json"); | ||
| if (existsSync(pkgJsonPath)) { | ||
| const ip = await doInstall(pkg, pkgDir); | ||
kylecarbs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (os.platform() === "win32") { | ||
| await ip; | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to not put node_modules into the container?
Right now yarn doesn't use it as a cache but it could in the future. See the comment in the Dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can add it back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://medium.com/@rdsubhas/docker-for-development-common-problems-and-solutions-95b25cae41eb
In linux we have linux binaries, on mac we have mac binaries, on windows we have exe files.
NPM is a hot mess, so node_modules should be git + docker ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this? I thought
node_modulesonly contained source code? Not actual binaries.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zerdos is right. Check the folder
node_modules/.bin/. There are modules that build executables in there (thenode-sasspackage is one that comes to mind. I don't think code-server uses it, but there are many other examples).