Skip to content

Latest version is named incorrectly #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckathleen opened this issue Jul 6, 2019 · 4 comments
Closed

Latest version is named incorrectly #833

ckathleen opened this issue Jul 6, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@ckathleen
Copy link

ckathleen commented Jul 6, 2019

  • code-server version: 1.1156-vsc1.33.1

  • OS Version: linux-x64, all cloud providers

Description

Throughout your documentation you write code-server-{version} but the latest linux version is named code-server{version}. There is no hyphen between the word server and the version string.

Steps to Reproduce

  1. Try to visit https://github.com/cdr/code-server/releases/download/1.1156-vsc1.33.1/code-server-1.1156-vsc1.33.1-linux-x64.tar.gz in your browser and it will fail to download
  2. Instead visit https://github.com/cdr/code-server/releases/download/1.1156-vsc1.33.1/code-server1.1156-vsc1.33.1-linux-x64.tar.gz and it will download!

Finders

@iyengarvinay and @ckathleen

@ckathleen ckathleen added the bug Something isn't working label Jul 6, 2019
@deansheather
Copy link
Member

This just seems like a documentation mistake. I looked back through a page of releases and none of them have a hyphen after code-server before the version. The GitHub releases are drafted for us by CI, which names and uploads the binaries for us, so it makes sense that it probably hasn't changed.

Would appreciate a PR that fixes the documentation. I think the only place that we say code-server-{version} is in our doc/admin/install/* guides.

@deansheather
Copy link
Member

Found a really old PR that seems to address this: #730. Asked for PGP signatures so we can merge it.

@ckathleen
Copy link
Author

ckathleen commented Jul 7, 2019 via email

@deansheather
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants