Skip to content

Locales are not available in local docker image #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gordon-to opened this issue Mar 7, 2019 · 2 comments
Closed

Locales are not available in local docker image #83

gordon-to opened this issue Mar 7, 2019 · 2 comments

Comments

@gordon-to
Copy link

gordon-to commented Mar 7, 2019 •
edited
Loading

  • code-server version: master
  • OS Version: 4.20.8-arch1-1-ARCH

not having locales can cause unexpected behaviour when working with text that is utf-8 encoded

Steps to Reproduce

  1. docker run -p 8443:8443 -v "${PWD}:/root/project" codercom/code-server code-server --allow-http --no-auth
  2. open terminal and type locale -a see en_US.UTF-8 is missing
@gordon-to gordon-to mentioned this issue Mar 7, 2019
Closed
@nhooyr
Copy link
Contributor

nhooyr commented Mar 7, 2019

@xMrWhite What issue are you seeing with this. I can output UTF-8 text fine. Do certain apps disable/enable UTF-8 based on the locale?

@nhooyr
Copy link
Contributor

nhooyr commented Mar 7, 2019 •
edited
Loading

Ah it seems they do. Python definitely has issues with this.

@nhooyr nhooyr mentioned this issue Mar 7, 2019
Merged
@nhooyr nhooyr closed this as completed in #98 Mar 7, 2019
code-asher pushed a commit that referenced this issue Jun 19, 2019
@nhooyr
Dockerfile: cleanup and add en_US.UTF-8 locale
e76296d 
Closes #84
Closes #83

Thanks @xMrWhite, @frol and @sr229.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate the en_US.UTF-8 locale in the docker image gordon-to/code-server
2 participants
@gordon-to @nhooyr