Extension is not enabled after restart

[wwbmmm]

• code-server version: v1.31.1-100
• OS Version: Ubuntu 18.10

Steps to Reproduce

1. Install one extension
2. restart code-server, then you can see all extensions is disabled, and can't be enabled again.

[kylecarbs]

Will investigate. Is this using the docker command?

[wwbmmm]

Will investigate. Is this using the docker command?

Yes, I use docker command, and use -d option to specify data directory to a docker volumn. So when I rerun docker command, the old data will be used.

[nhooyr]

@kylecarbs should we modify the one-liner to also mount a data directory?

[kylecarbs]

That's probably a good idea.

[nhooyr]

So in order to fix this, code-server needs to stop putting binaries into the data directory and reusing them as it'll screw with things on macOS for example. Best to use a temp dir or name the binaries with their OS and arch.

[fedelemantuano]

I have the same issue in

Distributor ID: Debian
Description:    Debian GNU/Linux 9.8 (stretch)
Release:        9.8
Codename:       stretch

With binary version:

server/0.0.0 linux-x64 node-v8.9.3
1.31.1-100

I use server without root permission.

[kylecarbs]

@nhooyr the only binary we unpack is ripgrep. That shouldn't prevent any loads though.

[nhooyr]

There is some pty.node binary in .code-server.

[fedelemantuano]

Yes. My data folder is in /var/lib/vscode and pty.node is in /var/lib/vscode/dependencies.

[kylecarbs]

It's probably best if we keep data in one place, and move temporary unpacked items to another folder. I suppose we could just keep them in <tmpdir>/code-server/