-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix FOUC issues in dark mode #7077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
These are probably best solved upstream, we are just wrapping VS Code's HTML. That said, having to select the theme multiple times sounds like a bug, and it could be a problem created by our patches. We patch the theme to be stored on the remote server, so as long as the config is not deleted from there it should keep using the same theme. |
Actually we may need to solve it here anyway because we should also style the login page with the current theme. #3019 |
I modified #3019 to include styling the VS Code page before it loads, since it will all be the same work, and will close this one as a duplicate. Thank you for the suggestion! |
@code-asher Your summary is very comprehensive, thank you, look forward to improvement. ❤️ |
No, because I'm using a brand new instance every time. |
Ahh I see. This is expected behavior, in that case. You could work around it by seeding each instance with a |
Yes, but:
|
Currently, after selecting the dark theme, every operation such as opening/closing a folder will produce a brief full-screen white screen flicker i.e.
FOUC (Flash of Unstyled Content)
, which is very unfriendly to the eyes.An additional question is that when the system/browser is in dark mode, the light theme is always the default when entering
code-server
. I always have to choose it manually. Maybe the matching theme should also be automatically applied?The text was updated successfully, but these errors were encountered: