Skip to content

Use theme colors on login page, error pages, and VS Code page before it loads #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks
nooobcoder opened this issue Apr 2, 2021 · 15 comments
Open
6 tasks
Labels
blocked This issue cannot proceed due to external factors feature New user visible feature
Milestone

Comments

@nooobcoder
Copy link

nooobcoder commented Apr 2, 2021

  • Grab VS Code theme colors and use those
    • Login page
    • Error pages
    • VS Code page (before it loads, to avoid the flash)
  • When theme colors are not available use system setting for light/dark
  • Possibly a toggle for light/dark mode
@nooobcoder nooobcoder added the feature New user visible feature label Apr 2, 2021
@code-asher
Copy link
Member

Maybe we could use the same theme VS Code is using? That could be cool.

@jsjoeio jsjoeio added this to the On Deck milestone Apr 2, 2021
@nooobcoder
Copy link
Author

@code-asher what about the shades of purple theme?
https://marketplace.visualstudio.com/items?itemName=ahmadawais.shades-of-purple

The color scheme is so good, maybe code-server should use it by default. Just a recommendation.

@nooobcoder
Copy link
Author

@jsjoeio @code-asher can I expect this feature in the next release 3.9.4 I am skipping updating to 3.9.3 as I could not see any major changes in code-server.

@code-asher
Copy link
Member

We don't have this on the 3.9.4 milestone; I think it's unlikely we'll get to it soon.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 12, 2021

Echoing Asher, this is a lower priority for us. We also have some changes happening across our internal/external projects, which would be related to this. cc @vapurrmaid

@greyscaled
Copy link
Contributor

greyscaled commented Apr 12, 2021

Echoing Asher, this is a lower priority for us. We also have some changes happening across our internal/external projects, which would be related to this. cc @vapurrmaid

Hey @jsjoeio - yea, I think this is more likely to land June or during the summer months thereafter, as our internal design system is being built out in our April and May iterations. This exact ticket and code-server is one of the first uses-cases I have in mind and am building for as an acceptance state for our design system.

@greyscaled greyscaled self-assigned this Apr 12, 2021
@greyscaled greyscaled added blocked This issue cannot proceed due to external factors and removed help-wanted labels Apr 12, 2021
@KaKi87
Copy link

KaKi87 commented Sep 11, 2021

Hello, any news on this ? Thanks

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 13, 2021

@KaKi87 not yet. It's still lower priority, but feel free to chime in with any thoughts around why this is important to you and what you'd like to see.

@greyscaled
Copy link
Contributor

I have an update: as of the September release of Coder, we've internally started on a design system and we've implemented theming in-product. While the design system is not fully fleshed out, it brings us one step closer to being able to achieve this ticket with the design system.

@KaKi87
Copy link

KaKi87 commented Sep 14, 2021

feel free to chime in with any thoughts around why this is important to you and what you'd like to see

More than anything, I would like to have a dark mode on it, even if it's a separate setting from VSCode, even if it's not following the theme's color code, although I would appreciate that too. 🙂

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 14, 2021

Dark mode would be awesome! Thanks for adding that. We'll add more updates as we have them like @vapurrmaid said so keep an eye on this issue!

@stale
Copy link

stale bot commented Mar 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Mar 13, 2022
@KaKi87
Copy link

KaKi87 commented Mar 13, 2022

Here's activity occuring.

@stale stale bot removed the stale label Mar 13, 2022
@LaCocoRoco
Copy link

I request a feature for a customizable login screen in this discussion #5569.
I will mark it as answered and hope for future progress in this issue.

@KaKi87
Copy link

KaKi87 commented Feb 1, 2023

In the meantime, for Dark Reader users, I created a Dark Reader dynamic blacklist userscript that, among other things, toggles Dark Reader on/off depending on routes for websites & webapps with incomplete theming.

I just added code-server support, which means the userscript will disable Dark Reader on any instance, except on login screens.

As you can see in the following screenshots, Dark Reader is enabled on both pages, but only affects the login page, and not the project page.

Login page Project page
Screenshot from 2023-02-01 05-34-54 Screenshot from 2023-02-01 05-34-28

I'm still looking forward to the login page adopting the user theme.

Thanks

@code-asher code-asher changed the title Feature request for default login page Use theme colors on login page Jun 29, 2023
@code-asher code-asher changed the title Use theme colors on login page Use theme colors on login page, error pages, and VS Code page before it loads Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue cannot proceed due to external factors feature New user visible feature
Projects
None yet
Development

No branches or pull requests

6 participants