Skip to content

[Feat]: Docker images based on other distributions #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsseng opened this issue Feb 3, 2024 · 3 comments · Fixed by #6669
Closed

[Feat]: Docker images based on other distributions #6661

dsseng opened this issue Feb 3, 2024 · 3 comments · Fixed by #6669
Labels
enhancement Some improvement that isn't a feature

Comments

@dsseng
Copy link
Contributor

dsseng commented Feb 3, 2024

What is your suggestion?

Build more Docker/OCI images using various distributions.

Why do you want this feature?

Some peoples' workflows are accustomed to a certain distro, personally I like using Fedora for development. It provides more cutting edge build-dependencies and is preferred for me.

Are there any workarounds to get this functionality today?

I just build images myself using modified version of code-server Dockerfile also installing wanted extra dependencies. I believe the Dockerfile is MIT as well thus fine to modify as long as I keep the copy of the license along with it, sorry if I'm wrong.

Are you interested in submitting a PR for this?

Yes, I'd be happy to upstream my Dockerfile for Fedora-based code-server if developers approve this. Maybe I could do openSUSE Tumbleweed as well as I use it often as well.

@dsseng dsseng added the enhancement Some improvement that isn't a feature label Feb 3, 2024
@code-asher
Copy link
Member

I believe the Dockerfile is MIT as well thus fine to modify as long as I keep the copy of the license along with it

Yup 👍

Yes, I'd be happy to upstream my Dockerfile for Fedora-based code-server if developers approve this. Maybe I could do openSUSE Tumbleweed as well as I use it often as well.

Please feel free, this sounds good to me.

@dsseng
Copy link
Contributor Author

dsseng commented Feb 7, 2024

Here's the latest version before I added more abstractions accomodating CLI editors and splitting base out: https://github.com/dsseng/fedora-development-containers/blob/baff02555eec68f70ec55a19867a859029e2a525/Dockerfile.code-server

This is quite a close reimplementation of the original Dockerfile. It uses GitHub releases and raw repo data to fetch rpm and container entrypoint respectively.

I'll submit a PR once this is considered decent option (also need to add CI stuff to generate those images). Also will try to do openSUSE Tumbleweed based one.

@code-asher
Copy link
Member

That looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants