Skip to content

X-Forwarded-Host can contain multiple hosts #6215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
code-asher opened this issue May 16, 2023 · 0 comments
Closed
4 tasks done

X-Forwarded-Host can contain multiple hosts #6215

code-asher opened this issue May 16, 2023 · 0 comments
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer

Comments

@code-asher
Copy link
Member

code-asher commented May 16, 2023

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

N/A

Steps to Reproduce

X-Forwarded-Host: <host>, <host>

Expected

We need to split this header and use the first.

Edit: actually unclear to me whether this is valid syntax for the header. While it does seem unusual the header is non-standard so this seems fair enough.

Actual

We use the whole thing.

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response

@code-asher code-asher added bug Something isn't working triage This issue needs to be triaged by a maintainer labels May 16, 2023
yiliang114 pushed a commit to yiliang114/code-server that referenced this issue Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant