-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[Bug]: code server goes to "Sleeping State" when closing the browser #5589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I believe this might be related to microsoft/vscode-remote-release#3096, but not sure. |
🤔 if that is related and it is upstream, we not be able to do much. cc @code-asher in case you have any thoughts/ideas! |
What do you mean by the process going into a sleeping state? I think VS Code kills terminal processes if they are not reconnected within a timeout, could that be the cause? |
Well, I think background jobs should be guaranteed alive by tmux, screen or something similiar, but not code-server. If you ssh to a remote server and run some jobs, you should not expect it to keep working after closing the ssh connection, so do code-server. |
Ah so the issue is that code-server is not terminating jobs when closing the browser? The reason they stay alive is in case the browser temporarily loses connectivity so it can reconnect the terminals once the network comes back up. It is supposed to eventually kill the jobs after a timeout I believe (I think it is five minutes). |
Closing as stale but feel free to comment if you come back to this. This behavior is defined by VS Code though so any changes will need to go there. |
Is there an existing issue for this?
OS/Web Information
code-server --version
: 4.7.0Steps to Reproduce
Expected
The server should be in a running state regardless of client connection
Actual
The code-server process should be in a running state but occasionally goes to a sleeping state.
This leads to other terminal child processes also going to a sleeping state.
Logs
Screenshot/Video
Does this issue happen in VS Code or GitHub Codespaces?
Are you accessing code-server over HTTPS?
Notes
I wonder if this is expected behavior.
The text was updated successfully, but these errors were encountered: