Skip to content

[Chore]: upgrade Code to 1.67 #5165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue May 5, 2022 · 11 comments · Fixed by #5263
Closed

[Chore]: upgrade Code to 1.67 #5165

jsjoeio opened this issue May 5, 2022 · 11 comments · Fixed by #5263
Assignees
Labels
chore Related to maintenance or clean up
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented May 5, 2022

No description provided.

@jsjoeio jsjoeio added enhancement Some improvement that isn't a feature chore Related to maintenance or clean up and removed enhancement Some improvement that isn't a feature labels May 5, 2022
@jsjoeio jsjoeio self-assigned this May 5, 2022
@jsjoeio jsjoeio added this to the May 2022 milestone May 5, 2022
@balajib-b
Copy link

balajib-b commented May 12, 2022

#https://github.com/microsoft/vscode/tree/1.67.2
VSCode 1.67.2 released.

@balajib-b
Copy link

Can we expect a release, Today (25th)?

@jsjoeio
Copy link
Contributor Author

jsjoeio commented May 25, 2022

Sadly, I think it might get delayed :( I had some other priorities come up. I'll update the milestone accordingly. I still need to upgrade us to 1.67 though.

@dx034
Copy link

dx034 commented Jun 9, 2022

All Copilot extensions compatible with 1.66 seemed to have stopped working, so it would be great if we could get an update to 1.67 soon.

@jsjoeio jsjoeio assigned code-asher and unassigned jsjoeio Jun 9, 2022
@balajib-b
Copy link

balajib-b commented Jun 10, 2022

@jsjoeio @code-asher 1.68 has been released now. can we jump to 1.68 directly or do we need to stick to the upgrade path strictly?

Can we have intermittent release with code-server upgraded to 1.68 and proceeed with test coverage milestone JUNE 2022? Is it possible?

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jun 10, 2022

We're low on bandwidth because the team is pushing for a big coder/coder release. I think we have to go one release at a time 🤔 but @code-asher might know better.

I'll still be doing some testing stuff because it's quick and what I'm able to contribute this month but @code-asher should be able to help with the VS Code upgrade soon.

@code-asher
Copy link
Member

I think one at a time is smart because there will likely be fewer conflicts to deal with at a time. I will probably try jumping straight to 1.68 and see if the conflicts are too gnarly. If so I will do 1.67 first.

@babytomas
Copy link

All Copilot extensions compatible with 1.66 seemed to have stopped working, so it would be great if we could get an update to 1.67 soon.

I tried to compile vscode 1.68 according to the "Version updates to Code" in the: https://coder.com/docs/code-server/latest/CONTRIBUTING , and it work's for me after manually resolving some file conflicts.

If you wanna use copilot, maybe you can try before code-server is updated.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jun 13, 2022

I tried to compile vscode 1.68 according to the "Version updates to Code" in the: https://coder.com/docs/code-server/latest/CONTRIBUTING , and it work's for me after manually resolving some file conflicts.

That's fantastic news! Thanks for letting us know!

@balajib-b
Copy link

@jsjoeio @code-asher can we expect a release as scheduled?

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jun 28, 2022

@balajib-b maybe by the end of this week? We have next week off but I will try my best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants