You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although I have not actually done this (uninstalling yarn is a pain), the postinstall script uses yarn so it will probably error that yarn cannot be found.
Logs
No response
Screenshot/Video
No response
Does this issue happen in VS Code?
I cannot reproduce this in VS Code.
Are you accessing code-server over HTTPS?
I am using HTTPS.
Notes
To fix:
Replace yarn with npm in npm-postinstall.sh
Generate shrinkwrap files for:
lib/vscode/package.json
lib/vscode/extensions/package.json
The text was updated successfully, but these errors were encountered:
Damn completely missed this.. I think I had something weird happening in my local dev box, and I was under the impression the upper-most one would take care of the dependencies. Let me try and take a stab at this, and also get something better on the way we generate that shrinkwrap file I might have discovered looking into this.
Ha no, the root-cause for missing this was that I validated the other change by using the package.tar.gz generated from the CI/the yarn command... which actually doesn't strip the yarn.lock files, so the versions were still deterministic.
The PR that generates the extra shrinkwrap files also adds an actual NPM release artifact - let me know if you'd rather have that done in a separate PR.
(And sorry for the long PR explanation, but hopefully it helps with the why's / sharing the context & knowledge.)
Is there an existing issue for this?
OS/Web Information
code-server --version
: developmentSteps to Reproduce
yarn build release
cd release && npm install
Expected
Install completes successfully.
Actual
Although I have not actually done this (uninstalling yarn is a pain), the postinstall script uses yarn so it will probably error that yarn cannot be found.
Logs
No response
Screenshot/Video
No response
Does this issue happen in VS Code?
Are you accessing code-server over HTTPS?
Notes
To fix:
yarn
withnpm
innpm-postinstall.sh
lib/vscode/package.json
lib/vscode/extensions/package.json
The text was updated successfully, but these errors were encountered: