Skip to content

[Bug]: Help > About reports code-server: vUnknown #5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
benz0li opened this issue Mar 24, 2022 · 0 comments
Closed
3 tasks done

[Bug]: Help > About reports code-server: vUnknown #5027

benz0li opened this issue Mar 24, 2022 · 0 comments
Assignees
@code-asher
Labels
bug Something isn't working
Milestone
4.3.0

Comments

@benz0li
Copy link
Contributor

benz0li commented Mar 24, 2022

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Firefox 98.0.1 (64-bit)
  • Local OS: macOS 12.3 (Monterey)
  • Remote OS: Debian bullseye
  • Remote Architecture: aarch64
  • code-server --version: 4.2.0 693b1fa with Code 1.64.2

Steps to Reproduce

  1. Open code-server
  2. Open Help > About

Expected

code-server: v4.2.0
VS Code: 1.64.2
Commit: 693b1fac04524bb0e0cfbb93afc85702263329bb
[...]

Actual

version

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code?

  • I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response
@benz0li benz0li added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Mar 24, 2022
@jsjoeio jsjoeio removed the triage This issue needs to be triaged by a maintainer label Mar 24, 2022
@jsjoeio jsjoeio added this to the April 2022 milestone Mar 24, 2022
@jsjoeio jsjoeio mentioned this issue Mar 25, 2022
Closed
3 tasks
code-asher added a commit to code-asher/code-server that referenced this issue Mar 31, 2022
@code-asher
Add code-server version to product configuration
858b042 
Before 1.64 the entire product configuration was sent to the client but
that was removed so we have to add anything we want to use on the
client, like the code-server version (used in the about dialog).

Fixes coder#5027.
code-asher added a commit to code-asher/code-server that referenced this issue Mar 31, 2022
@code-asher
Add code-server version to product configuration
8d79bc2 
Before 1.64 the entire product configuration was sent to the client but
that was removed so we have to add anything we want to use on the
client, like the code-server version (used in the about dialog).

Fixes coder#5027.
@jsjoeio jsjoeio modified the milestones: April 2022, 4.3.0 Apr 13, 2022
TinLe pushed a commit to TinLe/code-server that referenced this issue Apr 23, 2022
@code-asher @TinLe
fix: version in about dialog (coder#5057)
03449db 
* Fix code-server version not appearing in other languages

It needs to be separate from the localize call since the language
version of that string is used and it will not include a spot for the
code-server version.

I also moved the "v" so we do not get "vUnknown".

* Add code-server version to product configuration

Before 1.64 the entire product configuration was sent to the client but
that was removed so we have to add anything we want to use on the
client, like the code-server version (used in the about dialog).

Fixes coder#5027.

* Refresh patches

* Change version test to look for specific version

This will catch if we are not sending the actual version to the client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
4 participants
@misskniss @jsjoeio @benz0li @code-asher