Skip to content

[Bug]: No source map files in code-server v4.2.0 #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
benz0li opened this issue Mar 23, 2022 · 3 comments
Closed
3 tasks done

[Bug]: No source map files in code-server v4.2.0 #5026

benz0li opened this issue Mar 23, 2022 · 3 comments
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer

Comments

@benz0li
Copy link
Contributor

benz0li commented Mar 23, 2022

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Safari 15.4
  • Local OS: macOS 12.3 (Monterey)
  • Remote OS: Debian bullseye
  • Remote Architecture: amd64
  • code-server --version: 4.2.0 693b1fa with Code 1.64.2

Steps to Reproduce

  1. open code-server

Expected

No errors except Unrecognized Content-Security-Policy directive 'worker-src'.

Actual

console-errors

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code?

  • I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response
@benz0li benz0li added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Mar 23, 2022
@benz0li benz0li changed the title [Bug]: No _source map_ files in code-server v4.2.0 [Bug]: No source map files in code-server v4.2.0 Mar 23, 2022
@benz0li
Copy link
Contributor Author

benz0li commented Mar 23, 2022

I have noticed, that the Assets for v4.2.0 are ~90 MB smaller than the ones for v4.1.0.

ℹ️ There are no source map files although being pointed to in the JS files (e.g. in lib/vscode/out/vs/loader.js).

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 23, 2022 •
edited
Loading

cc @code-asher - any ideas on this one? Maybe I missed it in reviewing the patches PR?

@jsjoeio jsjoeio mentioned this issue Mar 23, 2022
Merged
2 tasks
@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 23, 2022

Definitely not intentional. I bet it is due to the switch to using Code's packaging task instead of cobbling it together ourselves. They might be removing the source maps because they host them elsewhere. So we might have to patch that removal out.

#5014 (comment)

code-asher added a commit to code-asher/code-server that referenced this issue Mar 29, 2022
@code-asher
Include source maps
53012b8 
I also moved this to its own patch because it feels sufficiently
standalone.

Fixes coder#5026.
code-asher added a commit to code-asher/code-server that referenced this issue Mar 29, 2022
@code-asher
Include source maps
cf1da20 
I also moved this to its own patch because it feels sufficiently
standalone.

Fixes coder#5026.
code-asher added a commit to code-asher/code-server that referenced this issue Mar 29, 2022
@code-asher
Include source maps
b2efe91 
I also moved this to its own patch because it feels sufficiently
standalone.

Fixes coder#5026.
code-asher added a commit to code-asher/code-server that referenced this issue Mar 29, 2022
@code-asher
Include source maps
ede7125 
I also moved this to its own patch because it feels sufficiently
standalone.

Fixes coder#5026.
TinLe pushed a commit to TinLe/code-server that referenced this issue Apr 23, 2022
@code-asher @TinLe
fix: add missing package.json and source maps (coder#5040)
afb39d9 
* Use --exclude to skip node_modules

Instead of copying and then deleting them.  This will also catch some
node_modules directories that were missed.

* Remove per-extension dependency install

Code packages all the dependencies using webpack for each extension so
there are no dependencies to install.

* Include source maps

I also moved this to its own patch because it feels sufficiently
standalone.

Fixes coder#5026.

* Refresh language patch

The base is slightly different so it needed to be refreshed.

* Add missing package.json

This was caused by switching to Code's package step which does not
include the package.json.

Fixes coder#5019.

* Include keytar

It seems this actually is used now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsjoeio @benz0li