Skip to content

V 4.0.0 gets confused on vscode-remote-resource in docker. #4604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geiseri opened this issue Dec 10, 2021 · 3 comments · Fixed by #4631
Closed

V 4.0.0 gets confused on vscode-remote-resource in docker. #4604

geiseri opened this issue Dec 10, 2021 · 3 comments · Fixed by #4631
Assignees
Labels
bug Something isn't working
Milestone

Comments

@geiseri
Copy link
Contributor

geiseri commented Dec 10, 2021

I have my setup behind a reverse proxy that provides SSL. It looks like the "vscode-remote-resource" has port 80 appended to the end.

https://code.house.geekcentral.io:80/vscode-remote-resource?path=%2Fhome%2Fcoder%2F.local%2Fshare%2Fcode-server%2Fextensions%2Fms-python.python-2021.10.1365161279%2Ficon.png&tkn=0000

This is installed as a PWA so I cleared it out completely with the same results.

I am not sure where port 80 comes from though. The docker serves out on 8080. For what it is worth the HAR for the request is below:

{
  "log": {
    "version": "1.2",
    "creator": {
      "name": "WebInspector",
      "version": "537.36"
    },
    "pages": [],
    "entries": [
      {
        "_initiator": {
          "type": "script",
          "stack": {
            "callFrames": [
              {
                "functionName": "mountTo",
                "scriptId": "9",
                "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                "lineNumber": 1282,
                "columnNumber": 14597
              },
              {
                "functionName": "buildMediaComponent",
                "scriptId": "9",
                "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                "lineNumber": 2782,
                "columnNumber": 101188
              },
              {
                "functionName": "selectStep",
                "scriptId": "9",
                "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                "lineNumber": 2782,
                "columnNumber": 103455
              },
              {
                "functionName": "buildCategorySlide",
                "scriptId": "9",
                "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                "lineNumber": 2914,
                "columnNumber": 16769
              },
              {
                "functionName": "buildCategoriesSlide",
                "scriptId": "9",
                "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                "lineNumber": 2914,
                "columnNumber": 3733
              },
              {
                "functionName": "setInput",
                "scriptId": "9",
                "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                "lineNumber": 2782,
                "columnNumber": 93599
              }
            ],
            "parent": {
              "description": "await",
              "callFrames": [
                {
                  "functionName": "doSetInput",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2340,
                  "columnNumber": 35105
                },
                {
                  "functionName": "doOpenEditor",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2340,
                  "columnNumber": 33409
                },
                {
                  "functionName": "openEditor",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2340,
                  "columnNumber": 33035
                },
                {
                  "functionName": "",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2541,
                  "columnNumber": 17075
                },
                {
                  "functionName": "doShowEditor",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2541,
                  "columnNumber": 17331
                },
                {
                  "functionName": "doOpenEditor",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2541,
                  "columnNumber": 16810
                },
                {
                  "functionName": "doCloseActiveEditor",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2541,
                  "columnNumber": 21373
                },
                {
                  "functionName": "doCloseEditor",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2541,
                  "columnNumber": 20694
                },
                {
                  "functionName": "doCloseEditorWithDirtyHandling",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2541,
                  "columnNumber": 20552
                }
              ]
            }
          }
        },
        "_priority": "VeryHigh",
        "_resourceType": "document",
        "cache": {},
        "connection": "51",
        "request": {
          "method": "GET",
          "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/index.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=https%3A%2F%2Fcode.house.geekcentral.io",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": ":method",
              "value": "GET"
            },
            {
              "name": ":authority",
              "value": "code.house.geekcentral.io"
            },
            {
              "name": ":scheme",
              "value": "https"
            },
            {
              "name": ":path",
              "value": "/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/index.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=https%3A%2F%2Fcode.house.geekcentral.io"
            },
            {
              "name": "sec-ch-ua",
              "value": "\" Not A;Brand\";v=\"99\", \"Chromium\";v=\"96\", \"Microsoft Edge\";v=\"96\""
            },
            {
              "name": "sec-ch-ua-mobile",
              "value": "?0"
            },
            {
              "name": "sec-ch-ua-platform",
              "value": "\"Windows\""
            },
            {
              "name": "upgrade-insecure-requests",
              "value": "1"
            },
            {
              "name": "user-agent",
              "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.55 Safari/537.36 Edg/96.0.1054.43"
            },
            {
              "name": "accept",
              "value": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9"
            },
            {
              "name": "sec-fetch-site",
              "value": "same-origin"
            },
            {
              "name": "sec-fetch-mode",
              "value": "navigate"
            },
            {
              "name": "sec-fetch-dest",
              "value": "iframe"
            },
            {
              "name": "referer",
              "value": "https://code.house.geekcentral.io/"
            },
            {
              "name": "accept-encoding",
              "value": "gzip, deflate, br"
            },
            {
              "name": "accept-language",
              "value": "en-US,en;q=0.9"
            },
            {
              "name": "cookie",
              "value": "<redacted>"
            }
          ],
          "queryString": [
            {
              "name": "id",
              "value": "d57e698a-d58e-4de9-962c-9fb6cd300788"
            },
            {
              "name": "swVersion",
              "value": "2"
            },
            {
              "name": "extensionId",
              "value": ""
            },
            {
              "name": "platform",
              "value": "browser"
            },
            {
              "name": "vscode-resource-base-authority",
              "value": "vscode-resource.vscode-webview.net"
            },
            {
              "name": "parentOrigin",
              "value": "https%3A%2F%2Fcode.house.geekcentral.io"
            }
          ],
          "cookies": [
            {
              "name": "_pomerium",
              "value": "<redacted>",
              "path": "/",
              "domain": ".house.geekcentral.io",
              "expires": "2021-12-11T12:09:56.073Z",
              "httpOnly": true,
              "secure": true
            },
            {
              "name": "vscode-tkn",
              "value": "0000",
              "path": "/",
              "domain": "code.house.geekcentral.io",
              "expires": "2021-12-17T22:09:56.092Z",
              "httpOnly": false,
              "secure": false,
              "sameSite": "Strict"
            }
          ],
          "headersSize": -1,
          "bodySize": 0
        },
        "response": {
          "status": 200,
          "statusText": "",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": "content-encoding",
              "value": "gzip"
            },
            {
              "name": "content-type",
              "value": "text/html"
            },
            {
              "name": "date",
              "value": "Fri, 10 Dec 2021 22:10:30 GMT"
            },
            {
              "name": "etag",
              "value": "W/\"2370721-517-1639000682000\""
            },
            {
              "name": "vary",
              "value": "Accept-Encoding"
            },
            {
              "name": "content-length",
              "value": "337"
            }
          ],
          "cookies": [],
          "content": {
            "size": 517,
            "mimeType": "text/html"
          },
          "redirectURL": "",
          "headersSize": -1,
          "bodySize": -1,
          "_transferSize": 389,
          "_error": null
        },
        "serverIPAddress": "10.0.5.15",
        "startedDateTime": "2021-12-10T22:10:30.132Z",
        "time": 22.86699999240227,
        "timings": {
          "blocked": 4.809000005574897,
          "dns": -1,
          "ssl": -1,
          "connect": -1,
          "send": 0.31300000000000006,
          "wait": 17.110999990474433,
          "receive": 0.6339999963529408,
          "_blocked_queueing": 4.186000005574897
        }
      },
      {
        "_initiator": {
          "type": "script",
          "stack": {
            "callFrames": [],
            "parent": {
              "description": "Image",
              "callFrames": [
                {
                  "functionName": "",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 76,
                  "columnNumber": 40192
                },
                {
                  "functionName": "je",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 76,
                  "columnNumber": 40059
                },
                {
                  "functionName": "Fe",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 76,
                  "columnNumber": 40267
                },
                {
                  "functionName": "iconWidgetFor",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2914,
                  "columnNumber": 11135
                },
                {
                  "functionName": "be",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2914,
                  "columnNumber": 7957
                },
                {
                  "functionName": "setEntries",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 1230,
                  "columnNumber": 59315
                },
                {
                  "functionName": "buildGettingStartedWalkthroughsList",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2914,
                  "columnNumber": 9307
                },
                {
                  "functionName": "buildCategoriesSlide",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2914,
                  "columnNumber": 2239
                },
                {
                  "functionName": "setInput",
                  "scriptId": "9",
                  "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                  "lineNumber": 2782,
                  "columnNumber": 93599
                }
              ],
              "parent": {
                "description": "await",
                "callFrames": [
                  {
                    "functionName": "doSetInput",
                    "scriptId": "9",
                    "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                    "lineNumber": 2340,
                    "columnNumber": 35105
                  },
                  {
                    "functionName": "doOpenEditor",
                    "scriptId": "9",
                    "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                    "lineNumber": 2340,
                    "columnNumber": 33409
                  },
                  {
                    "functionName": "openEditor",
                    "scriptId": "9",
                    "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                    "lineNumber": 2340,
                    "columnNumber": 33035
                  },
                  {
                    "functionName": "",
                    "scriptId": "9",
                    "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                    "lineNumber": 2541,
                    "columnNumber": 17075
                  },
                  {
                    "functionName": "doShowEditor",
                    "scriptId": "9",
                    "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                    "lineNumber": 2541,
                    "columnNumber": 17331
                  },
                  {
                    "functionName": "doOpenEditor",
                    "scriptId": "9",
                    "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                    "lineNumber": 2541,
                    "columnNumber": 16810
                  },
                  {
                    "functionName": "doCloseActiveEditor",
                    "scriptId": "9",
                    "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                    "lineNumber": 2541,
                    "columnNumber": 21373
                  },
                  {
                    "functionName": "doCloseEditor",
                    "scriptId": "9",
                    "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                    "lineNumber": 2541,
                    "columnNumber": 20694
                  },
                  {
                    "functionName": "doCloseEditorWithDirtyHandling",
                    "scriptId": "9",
                    "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                    "lineNumber": 2541,
                    "columnNumber": 20552
                  }
                ],
                "parent": {
                  "description": "await",
                  "callFrames": [
                    {
                      "functionName": "closeEditor",
                      "scriptId": "9",
                      "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                      "lineNumber": 2541,
                      "columnNumber": 20392
                    },
                    {
                      "functionName": "run",
                      "scriptId": "9",
                      "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                      "lineNumber": 2340,
                      "columnNumber": 81296
                    },
                    {
                      "functionName": "runAction",
                      "scriptId": "9",
                      "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                      "lineNumber": 191,
                      "columnNumber": 30604
                    },
                    {
                      "functionName": "run",
                      "scriptId": "9",
                      "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                      "lineNumber": 191,
                      "columnNumber": 30507
                    },
                    {
                      "functionName": "run",
                      "scriptId": "9",
                      "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                      "lineNumber": 2460,
                      "columnNumber": 17113
                    },
                    {
                      "functionName": "onClick",
                      "scriptId": "9",
                      "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                      "lineNumber": 191,
                      "columnNumber": 33621
                    },
                    {
                      "functionName": "",
                      "scriptId": "9",
                      "url": "https://code.house.geekcentral.io/static/out/vs/workbench/workbench.web.api.js",
                      "lineNumber": 191,
                      "columnNumber": 33177
                    }
                  ]
                }
              }
            }
          }
        },
        "_priority": "Low",
        "_resourceType": "image",
        "cache": {},
        "connection": "5764",
        "request": {
          "method": "GET",
          "url": "https://code.house.geekcentral.io:80/vscode-remote-resource?path=%2Fhome%2Fcoder%2F.local%2Fshare%2Fcode-server%2Fextensions%2Fms-python.python-2021.10.1365161279%2Ficon.png&tkn=0000",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": ":method",
              "value": "GET"
            },
            {
              "name": ":authority",
              "value": "code.house.geekcentral.io:80"
            },
            {
              "name": ":scheme",
              "value": "https"
            },
            {
              "name": ":path",
              "value": "/vscode-remote-resource?path=%2Fhome%2Fcoder%2F.local%2Fshare%2Fcode-server%2Fextensions%2Fms-python.python-2021.10.1365161279%2Ficon.png&tkn=0000"
            },
            {
              "name": "sec-ch-ua",
              "value": "\" Not A;Brand\";v=\"99\", \"Chromium\";v=\"96\", \"Microsoft Edge\";v=\"96\""
            },
            {
              "name": "sec-ch-ua-mobile",
              "value": "?0"
            },
            {
              "name": "user-agent",
              "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.55 Safari/537.36 Edg/96.0.1054.43"
            },
            {
              "name": "sec-ch-ua-platform",
              "value": "\"Windows\""
            },
            {
              "name": "accept",
              "value": "image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8"
            },
            {
              "name": "sec-fetch-site",
              "value": "same-site"
            },
            {
              "name": "sec-fetch-mode",
              "value": "no-cors"
            },
            {
              "name": "sec-fetch-dest",
              "value": "image"
            },
            {
              "name": "referer",
              "value": "https://code.house.geekcentral.io/"
            },
            {
              "name": "accept-encoding",
              "value": "gzip, deflate, br"
            },
            {
              "name": "accept-language",
              "value": "en-US,en;q=0.9"
            },
            {
              "name": "cookie",
              "value": "<redacted>"
            }
          ],
          "queryString": [
            {
              "name": "path",
              "value": "%2Fhome%2Fcoder%2F.local%2Fshare%2Fcode-server%2Fextensions%2Fms-python.python-2021.10.1365161279%2Ficon.png"
            },
            {
              "name": "tkn",
              "value": "0000"
            }
          ],
          "cookies": [
            {
              "name": "_pomerium",
              "value": "<redacted>",
              "path": "/",
              "domain": ".house.geekcentral.io",
              "expires": "2021-12-11T12:09:56.073Z",
              "httpOnly": true,
              "secure": true
            },
            {
              "name": "vscode-tkn",
              "value": "0000",
              "path": "/",
              "domain": "code.house.geekcentral.io",
              "expires": "2021-12-17T22:09:56.092Z",
              "httpOnly": false,
              "secure": false,
              "sameSite": "Strict"
            }
          ],
          "headersSize": -1,
          "bodySize": 0
        },
        "response": {
          "status": 404,
          "statusText": "",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": "content-type",
              "value": "text/plain; charset=utf-8"
            },
            {
              "name": "x-content-type-options",
              "value": "nosniff"
            },
            {
              "name": "content-length",
              "value": "19"
            },
            {
              "name": "date",
              "value": "Fri, 10 Dec 2021 22:10:30 GMT"
            }
          ],
          "cookies": [],
          "content": {
            "size": 0,
            "mimeType": "text/plain"
          },
          "redirectURL": "",
          "headersSize": -1,
          "bodySize": -1,
          "_transferSize": 0,
          "_error": null
        },
        "serverIPAddress": "10.0.5.15",
        "startedDateTime": "2021-12-10T22:10:30.141Z",
        "time": 5.594999995082617,
        "timings": {
          "blocked": 1.9469999884665012,
          "dns": -1,
          "ssl": -1,
          "connect": -1,
          "send": 0.369,
          "wait": 2.9040000033564866,
          "receive": 0.375000003259629,
          "_blocked_queueing": 1.1909999884665012
        }
      },
      {
        "_initiator": {
          "type": "parser",
          "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/index.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=https%3A%2F%2Fcode.house.geekcentral.io",
          "lineNumber": 15
        },
        "_priority": "Low",
        "_resourceType": "script",
        "cache": {},
        "connection": "51",
        "request": {
          "method": "GET",
          "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": ":method",
              "value": "GET"
            },
            {
              "name": ":authority",
              "value": "code.house.geekcentral.io"
            },
            {
              "name": ":scheme",
              "value": "https"
            },
            {
              "name": ":path",
              "value": "/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js"
            },
            {
              "name": "sec-ch-ua",
              "value": "\" Not A;Brand\";v=\"99\", \"Chromium\";v=\"96\", \"Microsoft Edge\";v=\"96\""
            },
            {
              "name": "origin",
              "value": "https://code.house.geekcentral.io"
            },
            {
              "name": "sec-ch-ua-mobile",
              "value": "?0"
            },
            {
              "name": "user-agent",
              "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.55 Safari/537.36 Edg/96.0.1054.43"
            },
            {
              "name": "sec-ch-ua-platform",
              "value": "\"Windows\""
            },
            {
              "name": "accept",
              "value": "*/*"
            },
            {
              "name": "sec-fetch-site",
              "value": "same-origin"
            },
            {
              "name": "sec-fetch-mode",
              "value": "cors"
            },
            {
              "name": "sec-fetch-dest",
              "value": "script"
            },
            {
              "name": "referer",
              "value": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/index.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=https%3A%2F%2Fcode.house.geekcentral.io"
            },
            {
              "name": "accept-encoding",
              "value": "gzip, deflate, br"
            },
            {
              "name": "accept-language",
              "value": "en-US,en;q=0.9"
            },
            {
              "name": "cookie",
              "value": "<redacted>"
            },
            {
              "name": "if-none-match",
              "value": "W/\"2370722-15732-1639000682000\""
            }
          ],
          "queryString": [],
          "cookies": [
            {
              "name": "_pomerium",
              "value": "<redacted>",
              "path": "/",
              "domain": ".house.geekcentral.io",
              "expires": "2021-12-11T12:09:56.073Z",
              "httpOnly": true,
              "secure": true
            },
            {
              "name": "vscode-tkn",
              "value": "0000",
              "path": "/",
              "domain": "code.house.geekcentral.io",
              "expires": "2021-12-17T22:09:56.092Z",
              "httpOnly": false,
              "secure": false,
              "sameSite": "Strict"
            }
          ],
          "headersSize": -1,
          "bodySize": 0
        },
        "response": {
          "status": 200,
          "statusText": "",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": "date",
              "value": "Fri, 10 Dec 2021 22:10:30 GMT"
            }
          ],
          "cookies": [],
          "content": {
            "size": 15732,
            "mimeType": "text/javascript"
          },
          "redirectURL": "",
          "headersSize": -1,
          "bodySize": -1,
          "_transferSize": 11,
          "_error": null
        },
        "serverIPAddress": "10.0.5.15",
        "startedDateTime": "2021-12-10T22:10:30.182Z",
        "time": 14.626999996835366,
        "timings": {
          "blocked": 3.0469999973401425,
          "dns": -1,
          "ssl": -1,
          "connect": -1,
          "send": 0.4850000000000001,
          "wait": 10.415000002121552,
          "receive": 0.6799999973736703,
          "_blocked_queueing": 1.8189999973401427
        }
      },
      {
        "_initiator": {
          "type": "other"
        },
        "_priority": "High",
        "_resourceType": "script",
        "cache": {},
        "request": {
          "method": "GET",
          "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/service-worker.js?id=d57e698a-d58e-4de9-962c-9fb6cd300788&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=https%3A%2F%2Fcode.house.geekcentral.io",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": "Referer",
              "value": ""
            }
          ],
          "queryString": [
            {
              "name": "id",
              "value": "d57e698a-d58e-4de9-962c-9fb6cd300788"
            },
            {
              "name": "swVersion",
              "value": "2"
            },
            {
              "name": "extensionId",
              "value": ""
            },
            {
              "name": "platform",
              "value": "browser"
            },
            {
              "name": "vscode-resource-base-authority",
              "value": "vscode-resource.vscode-webview.net"
            },
            {
              "name": "parentOrigin",
              "value": "https%3A%2F%2Fcode.house.geekcentral.io"
            }
          ],
          "cookies": [],
          "headersSize": -1,
          "bodySize": 0
        },
        "response": {
          "status": 200,
          "statusText": "",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": "date",
              "value": "Fri, 10 Dec 2021 22:10:30 GMT"
            },
            {
              "name": "content-encoding",
              "value": "gzip"
            },
            {
              "name": "etag",
              "value": "W/\"2370724-4615-1639000682000\""
            },
            {
              "name": "content-length",
              "value": "1792"
            },
            {
              "name": "vary",
              "value": "Accept-Encoding"
            },
            {
              "name": "content-type",
              "value": "text/javascript"
            }
          ],
          "cookies": [],
          "content": {
            "size": 4615,
            "mimeType": "text/javascript"
          },
          "redirectURL": "",
          "headersSize": -1,
          "bodySize": -1,
          "_transferSize": 16,
          "_error": null
        },
        "serverIPAddress": "10.0.5.15",
        "startedDateTime": "2021-12-10T22:10:30.334Z",
        "time": 3.572999994503334,
        "timings": {
          "blocked": -1,
          "dns": -1,
          "ssl": -1,
          "connect": -1,
          "send": 0,
          "wait": 0.3759999817702919,
          "receive": 3.1970000127330422,
          "_blocked_queueing": -1
        }
      },
      {
        "_initiator": {
          "type": "script",
          "stack": {
            "callFrames": [
              {
                "functionName": "",
                "scriptId": "41",
                "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                "lineNumber": 115,
                "columnNumber": 1825
              }
            ],
            "parent": {
              "description": "await",
              "callFrames": [
                {
                  "functionName": "",
                  "scriptId": "41",
                  "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                  "lineNumber": 114,
                  "columnNumber": 1515
                }
              ]
            }
          }
        },
        "_priority": "VeryHigh",
        "_resourceType": "document",
        "cache": {},
        "connection": "51",
        "request": {
          "method": "GET",
          "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/fake.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": ":method",
              "value": "GET"
            },
            {
              "name": ":authority",
              "value": "code.house.geekcentral.io"
            },
            {
              "name": ":scheme",
              "value": "https"
            },
            {
              "name": ":path",
              "value": "/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/fake.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788"
            },
            {
              "name": "sec-ch-ua",
              "value": "\" Not A;Brand\";v=\"99\", \"Chromium\";v=\"96\", \"Microsoft Edge\";v=\"96\""
            },
            {
              "name": "sec-ch-ua-mobile",
              "value": "?0"
            },
            {
              "name": "sec-ch-ua-platform",
              "value": "\"Windows\""
            },
            {
              "name": "upgrade-insecure-requests",
              "value": "1"
            },
            {
              "name": "user-agent",
              "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.55 Safari/537.36 Edg/96.0.1054.43"
            },
            {
              "name": "accept",
              "value": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9"
            },
            {
              "name": "sec-fetch-site",
              "value": "same-origin"
            },
            {
              "name": "sec-fetch-mode",
              "value": "navigate"
            },
            {
              "name": "sec-fetch-dest",
              "value": "iframe"
            },
            {
              "name": "referer",
              "value": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/index.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=https%3A%2F%2Fcode.house.geekcentral.io"
            },
            {
              "name": "accept-encoding",
              "value": "gzip, deflate, br"
            },
            {
              "name": "accept-language",
              "value": "en-US,en;q=0.9"
            },
            {
              "name": "cookie",
              "value": "<redacted>"
            }
          ],
          "queryString": [
            {
              "name": "id",
              "value": "d57e698a-d58e-4de9-962c-9fb6cd300788"
            }
          ],
          "cookies": [
            {
              "name": "_pomerium",
              "value": "<redacted>",
              "path": "/",
              "domain": ".house.geekcentral.io",
              "expires": "2021-12-11T12:09:56.073Z",
              "httpOnly": true,
              "secure": true
            },
            {
              "name": "vscode-tkn",
              "value": "0000",
              "path": "/",
              "domain": "code.house.geekcentral.io",
              "expires": "2021-12-17T22:09:56.092Z",
              "httpOnly": false,
              "secure": false,
              "sameSite": "Strict"
            }
          ],
          "headersSize": -1,
          "bodySize": 0
        },
        "response": {
          "status": 200,
          "statusText": "",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": "content-encoding",
              "value": "gzip"
            },
            {
              "name": "content-type",
              "value": "text/html"
            },
            {
              "name": "date",
              "value": "Fri, 10 Dec 2021 22:10:31 GMT"
            },
            {
              "name": "etag",
              "value": "W/\"2370720-243-1639000682000\""
            },
            {
              "name": "vary",
              "value": "Accept-Encoding"
            },
            {
              "name": "content-length",
              "value": "188"
            }
          ],
          "cookies": [],
          "content": {
            "size": 243,
            "mimeType": "text/html"
          },
          "redirectURL": "",
          "headersSize": -1,
          "bodySize": -1,
          "_transferSize": 213,
          "_error": null
        },
        "serverIPAddress": "10.0.5.15",
        "startedDateTime": "2021-12-10T22:10:30.401Z",
        "time": 974.226999998791,
        "timings": {
          "blocked": 961.0819999978188,
          "dns": -1,
          "ssl": -1,
          "connect": -1,
          "send": 0.252,
          "wait": 12.386999989744275,
          "receive": 0.506000011228025,
          "_blocked_queueing": 960.3829999978188
        }
      },
      {
        "_initiator": {
          "type": "script",
          "stack": {
            "callFrames": [],
            "parent": {
              "description": "Image",
              "callFrames": [
                {
                  "functionName": "",
                  "scriptId": "41",
                  "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                  "lineNumber": 115,
                  "columnNumber": 1881
                }
              ],
              "parent": {
                "description": "setTimeout",
                "callFrames": [
                  {
                    "functionName": "v",
                    "scriptId": "41",
                    "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                    "lineNumber": 115,
                    "columnNumber": 1854
                  },
                  {
                    "functionName": "",
                    "scriptId": "41",
                    "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                    "lineNumber": 115,
                    "columnNumber": 2258
                  }
                ]
              }
            }
          }
        },
        "_priority": "High",
        "_resourceType": "image",
        "cache": {},
        "connection": "51",
        "request": {
          "method": "GET",
          "url": "https://code.house.geekcentral.io/static/out/vs/workbench/contrib/welcome/gettingStarted/common/media/light.png",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": ":method",
              "value": "GET"
            },
            {
              "name": ":authority",
              "value": "code.house.geekcentral.io"
            },
            {
              "name": ":scheme",
              "value": "https"
            },
            {
              "name": ":path",
              "value": "/static/out/vs/workbench/contrib/welcome/gettingStarted/common/media/light.png"
            },
            {
              "name": "sec-ch-ua",
              "value": "\" Not A;Brand\";v=\"99\", \"Chromium\";v=\"96\", \"Microsoft Edge\";v=\"96\""
            },
            {
              "name": "sec-ch-ua-mobile",
              "value": "?0"
            },
            {
              "name": "user-agent",
              "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.55 Safari/537.36 Edg/96.0.1054.43"
            },
            {
              "name": "sec-ch-ua-platform",
              "value": "\"Windows\""
            },
            {
              "name": "accept",
              "value": "image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8"
            },
            {
              "name": "sec-fetch-site",
              "value": "same-origin"
            },
            {
              "name": "sec-fetch-mode",
              "value": "no-cors"
            },
            {
              "name": "sec-fetch-dest",
              "value": "image"
            },
            {
              "name": "referer",
              "value": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/index.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=https%3A%2F%2Fcode.house.geekcentral.io"
            },
            {
              "name": "accept-encoding",
              "value": "gzip, deflate, br"
            },
            {
              "name": "accept-language",
              "value": "en-US,en;q=0.9"
            },
            {
              "name": "cookie",
              "value": "<redacted>"
            },
            {
              "name": "if-none-match",
              "value": "W/\"2370741-14341-1639000682000\""
            }
          ],
          "queryString": [],
          "cookies": [
            {
              "name": "_pomerium",
              "value": "<redacted>",
              "path": "/",
              "domain": ".house.geekcentral.io",
              "expires": "2021-12-11T12:09:56.073Z",
              "httpOnly": true,
              "secure": true
            },
            {
              "name": "vscode-tkn",
              "value": "0000",
              "path": "/",
              "domain": "code.house.geekcentral.io",
              "expires": "2021-12-17T22:09:56.092Z",
              "httpOnly": false,
              "secure": false,
              "sameSite": "Strict"
            }
          ],
          "headersSize": -1,
          "bodySize": 0
        },
        "response": {
          "status": 200,
          "statusText": "",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": "date",
              "value": "Fri, 10 Dec 2021 22:10:31 GMT"
            }
          ],
          "cookies": [],
          "content": {
            "size": 14341,
            "mimeType": "image/png"
          },
          "redirectURL": "",
          "headersSize": -1,
          "bodySize": -1,
          "_transferSize": 11,
          "_error": null
        },
        "serverIPAddress": "10.0.5.15",
        "startedDateTime": "2021-12-10T22:10:31.498Z",
        "time": 17.519000015454367,
        "timings": {
          "blocked": 3.2940000149235127,
          "dns": -1,
          "ssl": -1,
          "connect": -1,
          "send": 0.6540000000000001,
          "wait": 12.97600001010485,
          "receive": 0.5949999904260039,
          "_blocked_queueing": 1.699000014923513
        }
      },
      {
        "_initiator": {
          "type": "script",
          "stack": {
            "callFrames": [],
            "parent": {
              "description": "Image",
              "callFrames": [
                {
                  "functionName": "",
                  "scriptId": "41",
                  "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                  "lineNumber": 115,
                  "columnNumber": 1881
                }
              ],
              "parent": {
                "description": "setTimeout",
                "callFrames": [
                  {
                    "functionName": "v",
                    "scriptId": "41",
                    "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                    "lineNumber": 115,
                    "columnNumber": 1854
                  },
                  {
                    "functionName": "",
                    "scriptId": "41",
                    "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                    "lineNumber": 115,
                    "columnNumber": 2258
                  }
                ]
              }
            }
          }
        },
        "_priority": "High",
        "_resourceType": "image",
        "cache": {},
        "connection": "51",
        "request": {
          "method": "GET",
          "url": "https://code.house.geekcentral.io/static/out/vs/workbench/contrib/welcome/gettingStarted/common/media/dark.png",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": ":method",
              "value": "GET"
            },
            {
              "name": ":authority",
              "value": "code.house.geekcentral.io"
            },
            {
              "name": ":scheme",
              "value": "https"
            },
            {
              "name": ":path",
              "value": "/static/out/vs/workbench/contrib/welcome/gettingStarted/common/media/dark.png"
            },
            {
              "name": "sec-ch-ua",
              "value": "\" Not A;Brand\";v=\"99\", \"Chromium\";v=\"96\", \"Microsoft Edge\";v=\"96\""
            },
            {
              "name": "sec-ch-ua-mobile",
              "value": "?0"
            },
            {
              "name": "user-agent",
              "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.55 Safari/537.36 Edg/96.0.1054.43"
            },
            {
              "name": "sec-ch-ua-platform",
              "value": "\"Windows\""
            },
            {
              "name": "accept",
              "value": "image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8"
            },
            {
              "name": "sec-fetch-site",
              "value": "same-origin"
            },
            {
              "name": "sec-fetch-mode",
              "value": "no-cors"
            },
            {
              "name": "sec-fetch-dest",
              "value": "image"
            },
            {
              "name": "referer",
              "value": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/index.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=https%3A%2F%2Fcode.house.geekcentral.io"
            },
            {
              "name": "accept-encoding",
              "value": "gzip, deflate, br"
            },
            {
              "name": "accept-language",
              "value": "en-US,en;q=0.9"
            },
            {
              "name": "cookie",
              "value": "<redacted>"
            },
            {
              "name": "if-none-match",
              "value": "W/\"2370732-14165-1639000682000\""
            }
          ],
          "queryString": [],
          "cookies": [
            {
              "name": "_pomerium",
              "value": "<redacted>",
              "path": "/",
              "domain": ".house.geekcentral.io",
              "expires": "2021-12-11T12:09:56.073Z",
              "httpOnly": true,
              "secure": true
            },
            {
              "name": "vscode-tkn",
              "value": "0000",
              "path": "/",
              "domain": "code.house.geekcentral.io",
              "expires": "2021-12-17T22:09:56.092Z",
              "httpOnly": false,
              "secure": false,
              "sameSite": "Strict"
            }
          ],
          "headersSize": -1,
          "bodySize": 0
        },
        "response": {
          "status": 200,
          "statusText": "",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": "date",
              "value": "Fri, 10 Dec 2021 22:10:31 GMT"
            }
          ],
          "cookies": [],
          "content": {
            "size": 14165,
            "mimeType": "image/png"
          },
          "redirectURL": "",
          "headersSize": -1,
          "bodySize": -1,
          "_transferSize": 11,
          "_error": null
        },
        "serverIPAddress": "10.0.5.15",
        "startedDateTime": "2021-12-10T22:10:31.498Z",
        "time": 19.79000002029352,
        "timings": {
          "blocked": 3.3330000247564167,
          "dns": -1,
          "ssl": -1,
          "connect": -1,
          "send": 0.39600000000000013,
          "wait": 15.259000000517815,
          "receive": 0.8019999950192869,
          "_blocked_queueing": 1.8570000247564167
        }
      },
      {
        "_initiator": {
          "type": "script",
          "stack": {
            "callFrames": [],
            "parent": {
              "description": "Image",
              "callFrames": [
                {
                  "functionName": "",
                  "scriptId": "41",
                  "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                  "lineNumber": 115,
                  "columnNumber": 1881
                }
              ],
              "parent": {
                "description": "setTimeout",
                "callFrames": [
                  {
                    "functionName": "v",
                    "scriptId": "41",
                    "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                    "lineNumber": 115,
                    "columnNumber": 1854
                  },
                  {
                    "functionName": "",
                    "scriptId": "41",
                    "url": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/main.js",
                    "lineNumber": 115,
                    "columnNumber": 2258
                  }
                ]
              }
            }
          }
        },
        "_priority": "High",
        "_resourceType": "image",
        "cache": {},
        "connection": "51",
        "request": {
          "method": "GET",
          "url": "https://code.house.geekcentral.io/static/out/vs/workbench/contrib/welcome/gettingStarted/common/media/monokai.png",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": ":method",
              "value": "GET"
            },
            {
              "name": ":authority",
              "value": "code.house.geekcentral.io"
            },
            {
              "name": ":scheme",
              "value": "https"
            },
            {
              "name": ":path",
              "value": "/static/out/vs/workbench/contrib/welcome/gettingStarted/common/media/monokai.png"
            },
            {
              "name": "sec-ch-ua",
              "value": "\" Not A;Brand\";v=\"99\", \"Chromium\";v=\"96\", \"Microsoft Edge\";v=\"96\""
            },
            {
              "name": "sec-ch-ua-mobile",
              "value": "?0"
            },
            {
              "name": "user-agent",
              "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.55 Safari/537.36 Edg/96.0.1054.43"
            },
            {
              "name": "sec-ch-ua-platform",
              "value": "\"Windows\""
            },
            {
              "name": "accept",
              "value": "image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8"
            },
            {
              "name": "sec-fetch-site",
              "value": "same-origin"
            },
            {
              "name": "sec-fetch-mode",
              "value": "no-cors"
            },
            {
              "name": "sec-fetch-dest",
              "value": "image"
            },
            {
              "name": "referer",
              "value": "https://code.house.geekcentral.io/webview/933bbd97-5653-4309-a3da-d54c24c31b9c/index.html?id=d57e698a-d58e-4de9-962c-9fb6cd300788&swVersion=2&extensionId=&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-webview.net&parentOrigin=https%3A%2F%2Fcode.house.geekcentral.io"
            },
            {
              "name": "accept-encoding",
              "value": "gzip, deflate, br"
            },
            {
              "name": "accept-language",
              "value": "en-US,en;q=0.9"
            },
            {
              "name": "cookie",
              "value": "<redacted>"
            },
            {
              "name": "if-none-match",
              "value": "W/\"2370743-14287-1639000682000\""
            }
          ],
          "queryString": [],
          "cookies": [
            {
              "name": "_pomerium",
              "value": "<redacted>",
              "path": "/",
              "domain": ".house.geekcentral.io",
              "expires": "2021-12-11T12:09:56.073Z",
              "httpOnly": true,
              "secure": true
            },
            {
              "name": "vscode-tkn",
              "value": "0000",
              "path": "/",
              "domain": "code.house.geekcentral.io",
              "expires": "2021-12-17T22:09:56.092Z",
              "httpOnly": false,
              "secure": false,
              "sameSite": "Strict"
            }
          ],
          "headersSize": -1,
          "bodySize": 0
        },
        "response": {
          "status": 200,
          "statusText": "",
          "httpVersion": "http/2.0",
          "headers": [
            {
              "name": "date",
              "value": "Fri, 10 Dec 2021 22:10:31 GMT"
            }
          ],
          "cookies": [],
          "content": {
            "size": 14287,
            "mimeType": "image/png"
          },
          "redirectURL": "",
          "headersSize": -1,
          "bodySize": -1,
          "_transferSize": 11,
          "_error": null
        },
        "serverIPAddress": "10.0.5.15",
        "startedDateTime": "2021-12-10T22:10:31.499Z",
        "time": 18.810000008670613,
        "timings": {
          "blocked": 2.880999998183921,
          "dns": -1,
          "ssl": -1,
          "connect": -1,
          "send": 0.30200000000000005,
          "wait": 14.789000003280119,
          "receive": 0.8380000072065741,
          "_blocked_queueing": 1.799999998183921
        }
      }
    ]
  }
}
@drmrbrewer
Copy link

drmrbrewer commented Dec 10, 2021

I'm also seeing an unexpected appearance of port 80: #4608

@code-asher
Copy link
Member

Thank you for the bug report! I have a good idea where this is.

@geiseri
Copy link
Contributor Author

geiseri commented Dec 13, 2021

lol, it's not like I haven't been hitting refresh on the release page hourly for the last week ;) I can't wait to see this release in its full glory!

@code-asher code-asher added the bug Something isn't working label Dec 13, 2021
code-asher added a commit to coder/vscode that referenced this issue Dec 14, 2021
Trying to determine the remote authority on the backend is brittle
because it does not work behind reverse proxies unless they send the
right headers containing information about the proxied source.

We could require users add the relevant configuration or provide the
remote authority via a flag but neither are user-friendly options.

We can make it work out of the box by changing the frontend to make
requests to its current address (which is what we try to set the remote
authority to anyway).  This actually already happens for the most part
except in some UI and logs although recent issues suggest there might be
other problems which should be entirely resolved by setting this on the
frontend.

In other words, the remote authority we set on the backend should never
be used so we set it to something invalid to ensure we notice (the
alternative is to rip it out but that is probably a bigger patch thus
generating more conflicts).

One scenario where we might want to set the remote authority from the
backend is if the frontend is served from a different location than the
backend but that is not supported behavior at the moment.  Even if we
did support this we still cannot determine the authority from the
backend (even for non-proxy scenarios in this case) and would need to
add a flag for it so this change would still be necessary.

coder/code-server#4604
coder/code-server#4607
coder/code-server#4608
@code-asher code-asher modified the milestones: 4.0.1, 4.0.0 Dec 14, 2021
code-asher added a commit to code-asher/code-server that referenced this issue Dec 15, 2021
Fixes coder#3410
Fixes coder#4604
Fixes coder#4607
Fixes coder#4608
Fixes coder#4609

Also has the foundation for
coder#4619.
jsjoeio pushed a commit that referenced this issue Dec 15, 2021
Fixes #3410
Fixes #4604
Fixes #4607
Fixes #4608
Fixes #4609

Also has the foundation for
#4619.
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
Trying to determine the remote authority on the backend is brittle
because it does not work behind reverse proxies unless they send the
right headers containing information about the proxied source.

We could require users add the relevant configuration or provide the
remote authority via a flag but neither are user-friendly options.

We can make it work out of the box by changing the frontend to make
requests to its current address (which is what we try to set the remote
authority to anyway).  This actually already happens for the most part
except in some UI and logs although recent issues suggest there might be
other problems which should be entirely resolved by setting this on the
frontend.

In other words, the remote authority we set on the backend should never
be used so we set it to something invalid to ensure we notice (the
alternative is to rip it out but that is probably a bigger patch thus
generating more conflicts).

One scenario where we might want to set the remote authority from the
backend is if the frontend is served from a different location than the
backend but that is not supported behavior at the moment.  Even if we
did support this we still cannot determine the authority from the
backend (even for non-proxy scenarios in this case) and would need to
add a flag for it so this change would still be necessary.

coder/code-server#4604
coder/code-server#4607
coder/code-server#4608
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
Trying to determine the remote authority on the backend is brittle
because it does not work behind reverse proxies unless they send the
right headers containing information about the proxied source.

We could require users add the relevant configuration or provide the
remote authority via a flag but neither are user-friendly options.

We can make it work out of the box by changing the frontend to make
requests to its current address (which is what we try to set the remote
authority to anyway).  This actually already happens for the most part
except in some UI and logs although recent issues suggest there might be
other problems which should be entirely resolved by setting this on the
frontend.

In other words, the remote authority we set on the backend should never
be used so we set it to something invalid to ensure we notice (the
alternative is to rip it out but that is probably a bigger patch thus
generating more conflicts).

One scenario where we might want to set the remote authority from the
backend is if the frontend is served from a different location than the
backend but that is not supported behavior at the moment.  Even if we
did support this we still cannot determine the authority from the
backend (even for non-proxy scenarios in this case) and would need to
add a flag for it so this change would still be necessary.

coder/code-server#4604
coder/code-server#4607
coder/code-server#4608
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this issue Dec 23, 2021
Trying to determine the remote authority on the backend is brittle
because it does not work behind reverse proxies unless they send the
right headers containing information about the proxied source.

We could require users add the relevant configuration or provide the
remote authority via a flag but neither are user-friendly options.

We can make it work out of the box by changing the frontend to make
requests to its current address (which is what we try to set the remote
authority to anyway).  This actually already happens for the most part
except in some UI and logs although recent issues suggest there might be
other problems which should be entirely resolved by setting this on the
frontend.

In other words, the remote authority we set on the backend should never
be used so we set it to something invalid to ensure we notice (the
alternative is to rip it out but that is probably a bigger patch thus
generating more conflicts).

One scenario where we might want to set the remote authority from the
backend is if the frontend is served from a different location than the
backend but that is not supported behavior at the moment.  Even if we
did support this we still cannot determine the authority from the
backend (even for non-proxy scenarios in this case) and would need to
add a flag for it so this change would still be necessary.

coder/code-server#4604
coder/code-server#4607
coder/code-server#4608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants