-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix password feature #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree |
I like that Ide @icebob. I will bring it up to the front end peeps. |
Wow, this code-server is amazing, thank you for such a great new tool! we will start using it in our agency... Password parameter for sure is important, otherwise user needs to login to ssh first, run the code-editor, copy the password, and only then be able to use it in the browser. |
@icebob feel free to create a PR for it! We'll also put it on the high-priority list :) |
Great! I will send it when I'm done. |
I'm confused since according to the docs |
$ ./code-server --help USAGE ARGUMENTS OPTIONS |
What I meant with my message is that if the flag is in the docs maybe it's a feature not pushed yet but already implemented. I don't know the roadmap, was just pointing that out. |
Docs updated with #5 icebob@e1099f0#diff-3e3c890e38761b2c49f651e11b921f9d |
While regular Math.Random is probably fine, we may want to look into using a CSPRNG. |
why not just use Nothing could possibly go wrong using the OS's Random device. |
With Windows support coming in the future, I doubt we'd want to use a OS dependent function. |
First of all, it's an awesome project. Thank you! By the way, do you plan to add fix password feature? Maybe it can be set as CLI argument like
./code-server --password 123456
.Or can I create a PR with this feature?
Keep up the good work!
The text was updated successfully, but these errors were encountered: