Skip to content

Fix password feature #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
icebob opened this issue Mar 5, 2019 · 12 comments
Closed

Fix password feature #4

icebob opened this issue Mar 5, 2019 · 12 comments

Comments

@icebob
Copy link
Contributor

icebob commented Mar 5, 2019

First of all, it's an awesome project. Thank you! By the way, do you plan to add fix password feature? Maybe it can be set as CLI argument like ./code-server --password 123456.

Or can I create a PR with this feature?

Keep up the good work!

@tvarwig
Copy link

tvarwig commented Mar 5, 2019

I agree

@nol166
Copy link
Contributor

nol166 commented Mar 5, 2019

I like that Ide @icebob. I will bring it up to the front end peeps.

@ddon
Copy link

ddon commented Mar 5, 2019

Wow, this code-server is amazing, thank you for such a great new tool! we will start using it in our agency... Password parameter for sure is important, otherwise user needs to login to ssh first, run the code-editor, copy the password, and only then be able to use it in the browser.

@kylecarbs
Copy link
Member

@icebob feel free to create a PR for it! We'll also put it on the high-priority list :)

@icebob
Copy link
Contributor Author

icebob commented Mar 5, 2019

Great! I will send it when I'm done.

icebob added a commit to icebob/code-server that referenced this issue Mar 5, 2019
kylecarbs pushed a commit that referenced this issue Mar 6, 2019
@Pitu
Copy link

Pitu commented Mar 6, 2019

I'm confused since according to the docs --password is a valid flag.

@ddon
Copy link

ddon commented Mar 6, 2019

$ ./code-server --help
Start your own self-hosted browser-accessible VS Code

USAGE
$ server [WORKDIR]

ARGUMENTS
WORKDIR [default: /home/xxx/code-server-1.31.0-x86_64-linux] Specify working dir

OPTIONS
-d, --data-dir=data-dir
-h, --host=host [default: 0.0.0.0]
-o, --open Open in browser on startup
-p, --port=port [default: 8443] Port to bind on
-v, --version show CLI version
--allow-http
--cert=cert
--cert-key=cert-key
--help show CLI help
--no-auth

@Pitu
Copy link

Pitu commented Mar 6, 2019

What I meant with my message is that if the flag is in the docs maybe it's a feature not pushed yet but already implemented. I don't know the roadmap, was just pointing that out.

@icebob
Copy link
Contributor Author

icebob commented Mar 6, 2019

Docs updated with #5 icebob@e1099f0#diff-3e3c890e38761b2c49f651e11b921f9d
But it's not released yet.

@NGTmeaty
Copy link
Contributor

NGTmeaty commented Mar 6, 2019

While regular Math.Random is probably fine, we may want to look into using a CSPRNG.

@sr229
Copy link
Contributor

sr229 commented Mar 6, 2019

why not just use /dev/urandom?

Nothing could possibly go wrong using the OS's Random device.

@NGTmeaty
Copy link
Contributor

NGTmeaty commented Mar 6, 2019

With Windows support coming in the future, I doubt we'd want to use a OS dependent function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants