Skip to content

Improve types for loader in src/browser/pages/vscode #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Jul 14, 2021 · 1 comment
Closed

Improve types for loader in src/browser/pages/vscode #3780

jsjoeio opened this issue Jul 14, 2021 · 1 comment
Labels
testing Anything related to testing
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 14, 2021

This is a follow-up item to #3760

Notes

Inside vscode.ts, we use (self.require as FixMeLater) = loader to add the loader. I'm not sure the proper way to type this since require is a property we're defining on self.

@code-asher also notes:

Maybe we can copy down the .d.ts for the loader to get the right type.

This might be a lot of work though, not sure. We also might need to load loader.js first and then do require.config(config) instead.

I think additional context is needed in order for this to be worked on.

Link to Loader upstream: https://github.com/microsoft/vscode-loader/blob/main/src/loader.d.ts#L280

@jsjoeio jsjoeio added the feature New user visible feature label Jul 14, 2021
@jsjoeio jsjoeio added testing Anything related to testing and removed feature New user visible feature labels Jul 14, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Jul 14, 2021
@stale
Copy link

stale bot commented Jan 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Jan 11, 2022
@stale stale bot closed this as completed Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

No branches or pull requests

1 participant