Skip to content

preference doesn't save #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shi-yan opened this issue Mar 23, 2019 · 8 comments
Closed

preference doesn't save #321

shi-yan opened this issue Mar 23, 2019 · 8 comments
Labels
bug Something isn't working

Comments

@shi-yan
Copy link

shi-yan commented Mar 23, 2019

  • code-server version: tot
  • OS Version: ubuntu 18.04 in docker and on host

Description

I tried to config the shortcut, and it doesn't save. if I refresh the browser, the old default preference comes back.

Steps to Reproduce

@shi-yan shi-yan added the bug Something isn't working label Mar 23, 2019
@vimota
Copy link

vimota commented Mar 24, 2019

Does it work if you do something like docker run -t -p 127.0.0.1:8443:8443 -v "$HOME/path/to/project:/root/project" -v "/$HOME/.coder:/root/.local" codercom/code-server --allow-http --no-auth ? The preferences should be saved in /root/.local/ which will be stored in your /$HOME/.coder, and preserved between sessions.

@sr229
Copy link
Contributor

sr229 commented Mar 26, 2019

Can't reproduce this issue. I don't think this persists anymore.

@shi-yan
Copy link
Author

shi-yan commented Mar 26, 2019

Screenshot from 2019-03-26 11-44-36

This is still happening to me. the specific config I need to change is keyboard binding. The result of the change should be in keybindings.json, which I verified is there with the right content.

but if I close the browser tab and reconnect, the keybindings won't change at all. it doesn't seem to load the json file.

@sr229
Copy link
Contributor

sr229 commented Mar 27, 2019

So this is only for keybindings I presume? Other preferences saves fine

@RyanK1m
Copy link

RyanK1m commented Mar 28, 2019

Same here.
Custom keybinding works properly when you first customize them.
When reload, default keybinding overwrites it.
If you open up custom keybindings again and just save it, custom keybinding works again.

Other preferences save just fine.

@weikinhuang
Copy link

same issue here from me #150

@sr229
Copy link
Contributor

sr229 commented Mar 29, 2019

This might be a confirmed bug, I can confirm this on CoreOS

@kylecarbs
Copy link
Member

Duplicate of #321

@kylecarbs kylecarbs marked this as a duplicate of #321 Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants