Skip to content

no need for the close/minimize/maximize buttons #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shi-yan opened this issue Mar 22, 2019 · 5 comments · Fixed by #550
Closed

no need for the close/minimize/maximize buttons #320

shi-yan opened this issue Mar 22, 2019 · 5 comments · Fixed by #550
Assignees
Labels
bug Something isn't working

Comments

@shi-yan
Copy link

shi-yan commented Mar 22, 2019

  • code-server version: top of tree
  • OS Version: ubuntu 18.04 for both host and docker

Description

code-server still has the minimize, maximize and close window button on the top right corner. they are not functioning and should be removed.

Steps to Reproduce

@shi-yan shi-yan added the bug Something isn't working label Mar 22, 2019
@nol166
Copy link
Contributor

nol166 commented Mar 25, 2019

@shi-yan Can you send a screenshot when you get a chance?

@shi-yan
Copy link
Author

shi-yan commented Mar 25, 2019

Selection_004

this is only a problem on linux, I don't see the same buttons on mac. (not sure about windows)

@nol166
Copy link
Contributor

nol166 commented Mar 25, 2019

@shi-yan Interesting. Thank you for sharing this

@shi-yan
Copy link
Author

shi-yan commented Mar 25, 2019

Screenshot from 2019-03-25 11-44-11

you know, the other side of this bug is, on mac, you can't find the preference /setting menu. I don't have a mac at hand, so I can't show you the mac screenshot. but on linux, under the file menu, there is a preference /setting menu. this is not shown on mac. (so that I have no idea how to config preference.)

I guess the electron replacement layer shows different UIs on different client platforms. it tries to look native, that's why we see the close button on linux and no preference menu on mac.

@nol166
Copy link
Contributor

nol166 commented Mar 25, 2019

If you use the command pallet does it let you get to the settings that way, either UI or JSON?

Definitely a bug though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants