Regression: New RegExp format causes blank page

[L3P3]

OS/Web Information

• Web Browser: Mypal 29.1.1 (Pale Moon/Firefox)
• Local OS: Windows XP SP3
• Remote OS: Debian 10
• Remote Architecture: x86-64
• code-server --version: 3.9.2 109d2ce

Steps to Reproduce

1. Open Mypal
2. Open code-server

Expected

App opens.

Actual

Blank page.

Screenshot

Notes

Is most probably caused by following lines including quite recent RegExp syntax:

https://github.com/cdr/code-server/blob/f21433a130ab07db569a1ae43a04416e7ec306ba/lib/vscode/src/vs/editor/contrib/linesOperations/linesOperations.ts#L1060

Please either revert these lines (v3.9.0 it worked well) or make them more backwards-compatible (maybe feature check and fallback). Maybe, we can also consider this a bug in closure compiler as it should generate backwards-compatible code out of the box.

[jsjoeio]

Hi @L3P3! Thanks for opening the issue.

This issue can be reproduced in VS Code: Yes/No

It looks like part of the bug report is missing this line. Can this be reproduced in VS Code?

Based on what you linked, if that's truly the issue, then it looks like it was introduced/changed here: microsoft/vscode@5c1ff81#diff-dde3b56145713053f086e5ce1fcea39c4cb171d4555b6ab91256c7cf2b39e9af

We suggest raising this upstream.

Maybe, we can also consider this a bug in closure compiler as it should generate backwards-compatible code out of the box.

If that's the case, it may be worth raising this there.

[L3P3]

Thanks for pointing that out. Did not know that vscode aims for backwards-compatiblity and I thought it is just used in modern electron.
Workaround for now is to simply delete SnakeCaseAction, I will now look into the compiler side of things.

[repo-ranger]

This issue has been marked as 'upstream:vscode'. Please file this upstream: link to open issue"
This issue will automatically close in 5 seconds.

[L3P3]

Just for the record, if anyone else has this problem, run this command on your server:

sudo sed -i 's#return q\.replace(/(\\p{Ll})(\\p{Lu})/gmu,\"\$1_\$2\")\.replace(/(\[^\\b_\])(\\p{Lu})(\\p{Ll})/gmu,\"\$1_\$2\$3\")\.toLocaleLowerCase()#return eval('\''q\.replace(/(\\\\p{Ll})(\\\\p{Lu})/gmu,\"\$1_\$2\")\.replace(/(\[^\\\\b_\])(\\\\p{Lu})(\\\\p{Ll})/gmu,\"\$1_\$2\$3\")\.toLocaleLowerCase()'\'')#g' /usr/lib/code-server/lib/vscode/out/vs/workbench/workbench.web.api.js

With this, automatic snake case transformation is still not working but at least, everything else does. In newer browsers, everything still works as before.

Updated for v3.10.0:

sudo sed -i 's#return G\.replace(/(\\p{Ll})(\\p{Lu})/gmu,\"\$1_\$2\")\.replace(/(\\p{Lu}|\\p{N})(\\p{Lu})(\\p{Ll})/gmu,\"\$1_\$2\$3\")\.toLocaleLowerCase()#return eval('\''G\.replace(/(\\\\p{Ll})(\\\\p{Lu})/gmu,\"\$1_\$2\")\.replace(/(\\\\p{Lu}|\\\\p{N})(\\\\p{Lu})(\\\\p{Ll})/gmu,\"\$1_\$2\$3\")\.toLocaleLowerCase()'\'')#g' /usr/lib/code-server/lib/vscode/out/vs/workbench/workbench.web.api.js