Skip to content

Create extension directory if not found #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Apr 5, 2021 · 0 comments · Fixed by #3309
Closed

Create extension directory if not found #3040

jsjoeio opened this issue Apr 5, 2021 · 0 comments · Fixed by #3309
Assignees
Labels
enhancement Some improvement that isn't a feature
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 5, 2021

Occasionally in CI or locally, we will see this error produced by code-server:

ERR /home/runner/.local/share/code-server/extensions [Error: ENOENT: no such file or directory, scandir '/home/runner/.local/share/code-server/extensions'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: '/home/runner/.local/share/code-server/extensions'
}

@code-asher says we can create environmentService.globalStorageHome and could add the ext dir there to prevent this error. Similar to how GitPod does it: https://github.com/gitpod-io/vscode/blob/gp-code/src/vs/gitpod/node/server.ts#L330

@jsjoeio jsjoeio added enhancement Some improvement that isn't a feature help-wanted labels Apr 5, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Apr 5, 2021
@code-asher code-asher self-assigned this Apr 26, 2021
@code-asher code-asher modified the milestones: On Deck, v3.9.4 Apr 26, 2021
code-asher added a commit to code-asher/code-server that referenced this issue May 7, 2021
code-asher added a commit to code-asher/code-server that referenced this issue May 7, 2021
code-asher added a commit to code-asher/code-server that referenced this issue May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants