Skip to content

Log out button should not appear if not using password #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alvarolb opened this issue Mar 27, 2021 · 1 comment · Fixed by #3277
Closed

Log out button should not appear if not using password #2985

alvarolb opened this issue Mar 27, 2021 · 1 comment · Fixed by #3277
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alvarolb
Copy link

OS/Web Information

  • Web Browser: Chrome
  • Local OS: Linux Ubuntu
  • Remote OS: Linux Ubuntu
  • Remote Architecture: x64
  • code-server --version: 3.9.2

Steps to Reproduce

  1. Run code-server without password
  2. Click on Menu button
  3. Log out button is there but has no sense as not using password

Expected

Log out button should not appear, as the installation is not using a password

Actual

The log out button appears even if not using a password. In my case I am using code-server inside a reverse proxy that already handles authentication, so, the log out button has no sense in such use cases

Screenshot

image

Notes

This issue can be reproduced in VS Code: No

@jsjoeio jsjoeio added the bug Something isn't working label Mar 29, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Mar 29, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 29, 2021

Good call! We didn't consider that when adding the Log out feature. Thanks for bringing this to our attention! Added to an upcoming milestone.

@code-asher code-asher self-assigned this Apr 26, 2021
@code-asher code-asher modified the milestones: On Deck, v3.9.4 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants