Link to FAQ on Welcome page is incorrect #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

MarkAYoder opened this issue Feb 13, 2021 · 4 comments

Assignees

Milestone

MarkAYoder commented Feb 13, 2021

https://github.com/cdr/code-server/blob/41ad0c0c4c14df78e1bfa3a44d8b633ed2fc26e5/lib/vscode/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts#L42

The above has doc/FAQ.md but should be docs/FAQ.md

--Mark

Author

MarkAYoder commented Feb 13, 2021

There's more than one "doc" that should be "docs".

https://github.com/cdr/code-server/blob/41ad0c0c4c14df78e1bfa3a44d8b633ed2fc26e5/lib/vscode/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts#L42-L44

Contributor

JammSpread commented Feb 15, 2021

Not only are these links incorrect but also the unofficial extensions warning seems to use the doc path.

Contributor

jsjoeio commented Feb 18, 2021

Thanks for the catch! I didn't realize there was more than one. I'll fix all of these in #2743

jsjoeio self-assigned this

jsjoeio added this to the v3.9.1 milestone

Contributor

jsjoeio commented Feb 24, 2021

Closing via #2743

jsjoeio closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment