Skip to content

when I use port forward in edge/chrome, I got OFFLINE page. #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nobody4t opened this issue Aug 18, 2020 · 2 comments
Closed

when I use port forward in edge/chrome, I got OFFLINE page. #1979

nobody4t opened this issue Aug 18, 2020 · 2 comments

Comments

@nobody4t
Copy link

  • Web Browser: edge/chrome
  • Local OS: mac
  • Remote OS: ubuntu 18.0
  • Remote Architecture: amd64
  • code-server --version: 0,34.1

Screen Shot 2020-08-18 at 11 01 55

@nobody4t
Copy link
Author

It recovered after 2 hours. Is this a bug or something condfig issue?

@code-asher
Copy link
Member

code-asher commented Aug 18, 2020

This happens whenever navigator.onLine reports false but in your case I'm not sure why it's doing that. But we're going to remove this check entirely in a future release so it shouldn't be a problem. Tracking for this here: #1925

code-asher added a commit that referenced this issue Aug 26, 2020
We need the handler to be recognized as a PWA but we can just let the
original offline browser message show instead of our own message.

See #1925 and #1979.
code-asher added a commit that referenced this issue Aug 27, 2020
We need the handler to be recognized as a PWA but we can just let the
original offline browser message show instead of our own message.

See #1925 and #1979.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants