Skip to content

Target Node 12 #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
code-asher opened this issue Jul 21, 2020 · 2 comments · Fixed by #1998
Closed

Target Node 12 #1894

code-asher opened this issue Jul 21, 2020 · 2 comments · Fixed by #1998
Assignees
@nhooyr
Labels
bug Something isn't working
Milestone
v3.5.0

Comments

@code-asher
Copy link
Member

We'll need to target the same version as VS Code to fix these issues:

#1892
#1810
@nhooyr nhooyr self-assigned this Jul 21, 2020
@nhooyr nhooyr added the bug Something isn't working label Jul 21, 2020
@code-asher
Copy link
Member Author

code-asher commented Jul 21, 2020 •
edited
Loading

Relevant: #1898 (need at least 12.18.1).

nhooyr added a commit that referenced this issue Jul 22, 2020
@nhooyr
Ship with node 12
beb1bf7 
Closes #1894
nhooyr added a commit that referenced this issue Jul 22, 2020
@nhooyr
Ship with node 12
c2e6228 
Closes #1894
nhooyr added a commit that referenced this issue Jul 22, 2020
@nhooyr
Ship with node 12
3381d99 
Closes #1894
Closes #1892
Closes #1810
@nhooyr nhooyr mentioned this issue Jul 22, 2020
Closed
code-asher pushed a commit that referenced this issue Aug 19, 2020
@nhooyr @code-asher
Ship with node 12
c51daaf 
Closes #1894
Closes #1892
Closes #1810
nhooyr added a commit that referenced this issue Aug 25, 2020
@nhooyr
Ship with node 12
dc0bb4f 
Closes #1894
Closes #1892
Closes #1810
@nhooyr nhooyr mentioned this issue Aug 25, 2020
Merged
nhooyr added a commit that referenced this issue Aug 26, 2020
@nhooyr
Ship with node 12 (#1998)
a730bec 
See #1894
See #1892
See #1810
@nhooyr nhooyr added this to the v3.5.0 milestone Aug 31, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Aug 31, 2020

v3.5.0 with VS Code v1.48.2 has been released, fixing this issue! 🍻

@nhooyr nhooyr closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhooyr nhooyr

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging a pull request may close this issue.

Ship with node 12 coder/code-server
Ship with node 12 coder/code-server
2 participants
@nhooyr @code-asher