repo: vscode should be a submodule #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

nhooyr opened this issue Mar 9, 2019 · 3 comments

Contributor

nhooyr commented Mar 9, 2019

Makes more sense than cloning in the build script.

nhooyr added the build label

Contributor Author

nhooyr commented Mar 9, 2019

Also, see my recent PR that fixed a bug with the cloning not fetching latest changes.

Contributor Author

nhooyr commented Mar 9, 2019

Member

kylecarbs commented Apr 24, 2019

No longer relevant as we download it based on version to speed up builds.

kylecarbs closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment