Skip to content

Why duplicate releases and tags? #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SuperSandro2000 opened this issue Jun 4, 2020 · 4 comments
Closed

Why duplicate releases and tags? #1770

SuperSandro2000 opened this issue Jun 4, 2020 · 4 comments
Labels
blocked This issue cannot proceed due to external factors
Milestone
v3.5.0

Comments

@SuperSandro2000
Copy link
Contributor

Does this project use git tags with v or without v? This changed multi times in the last releases which is very confusing and breaks my CI everytime.
@nhooyr
Copy link
Contributor

nhooyr commented Jun 4, 2020

See #1758

@nhooyr
Copy link
Contributor

nhooyr commented Jun 4, 2020

My bad, I forgot this changes the latest version for downstream projects pulling code-server.

The release without the v exists only for autoupdates. Context in the above link.

@nhooyr nhooyr pinned this issue Jun 4, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Jun 4, 2020

Yea not sure if we can do anything here now, I don't want to republish two releases again. We wanted to give at least a few weeks for autoupdates to take place.

cc @code-asher

To be clear, the tag with the v is the main one. The other is purely for autoupdating users on older versions. If you can, I'd recommend using our install script which handles these things properly.

@nhooyr nhooyr changed the title How are git tags structured? Why duplicate releases and tags? Jun 4, 2020
@nhooyr nhooyr added the blocked This issue cannot proceed due to external factors label Jun 4, 2020
@nhooyr nhooyr added this to the v3.5.0 milestone Aug 31, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Aug 31, 2020

v3.5.0 with VS Code v1.48.2 has been released, fixing this issue! 🍻

No more tag duplication!

@nhooyr nhooyr closed this as completed Aug 31, 2020
@nhooyr nhooyr unpinned this issue Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This issue cannot proceed due to external factors
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
2 participants
@SuperSandro2000 @nhooyr