Listening on INADDR6_ANY not possible

[Grimeton]

Hi,

when starting the server while trying to listen on INADDR6_ANY, also known as "::", the server errors out. It's not accepting a simple "::". According to RFC4038 the addresses should be placed in brackets, even when not using a port, so the "::" turns into "[::]", doesn't work either.

After switching to the --bind-addr parameter the situation got worse, because now, using "::" together with a port isn't possible anymore. When following RFC4038 I'm neither able to use "[::]", nor "[::]:1234".

Same happens with INADDR6_LOOPBACK, e.g. "::1" or "[::1]" or "[::1]:1234".

KR,

G.

[nhooyr]

Nice catch!

[code-asher]

Fixed and will be in 3.6.0.

[cycl0ne]

still not working or im not using the config.yaml correct, got the same errors with bind-addr:

Running with 3.10.2

running with: --host :: works

[code-asher]

@cycl0ne something like this should work:

bind-addr: "[1234:1234:1234::1234]:443"

If it doesn't could you open a new issue with the bind-addr line you are trying to use and the code-server output? Thanks!

[despiegk]

root@vm1:~# code-server --host ::
[2022-01-08T03:16:47.810Z] info  code-server 4.0.1 735c6da829535969ff7193c79379299e4a1cb9bc
[2022-01-08T03:16:47.812Z] info  Using user-data-dir ~/.local/share/code-server
[2022-01-08T03:16:47.834Z] error Invalid URL: http://:::8080

root@vm1:~# code-server --host "[::]:8080"
[2022-01-08T03:17:02.380Z] info  code-server 4.0.1 735c6da829535969ff7193c79379299e4a1cb9bc
[2022-01-08T03:17:02.383Z] info  Using user-data-dir ~/.local/share/code-server
[2022-01-08T03:17:02.425Z] error getaddrinfo ENOTFOUND ::]:808

doesn't work for me

[jsjoeio]

cc @code-asher - any ideas?^

[code-asher]

--bind-addr "[::]:8080" should be correct but it seems changes to ensureAddress broke IPv6. Node expects :: but URL expects [::] so we have to convert.

Here we convert when listening:

code-server/src/node/app.ts

Lines 46 to 47 in ca15d4b

	// [] is the correct format when using :: but Node errors with them.
	server.listen(port, host.replace(/^\[|\]$/g, ""), onListen)

Se we could need to convert here as well:

code-server/src/node/app.ts

Line 93 in ca15d4b

return new URL(`${protocol}://${addr.address}:${addr.port}`)

We can probably just check if it has : and if so wrap it in brackets.

[code-asher]

Actually there is a family property we can use to see if it is IPv6.

[GamingRebirth]

It still does not work for me. Using version 4.1.0

[qiurigao]

It still does not work for me. Using version 4.3.0

[jsjoeio]

This hasn't been fixed yet. But we think we can fix it in the near future.

[jsjoeio]

PRs welcome!