Skip to content

Version information is not displayed in About pane #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Merith-TK opened this issue Apr 10, 2020 · 5 comments
Closed

Version information is not displayed in About pane #1506

Merith-TK opened this issue Apr 10, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Merith-TK
Copy link
Contributor

Merith-TK commented Apr 10, 2020

Reports itself as

Version: 1.43.2
Commit: 5aded14b87e017d32d080b686515f6a26be455f1
Date: 2020-04-09T19:12:56.263Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36 Edg/80.0.361.111

image

@Merith-TK Merith-TK changed the title v3.1.0 v3.1.0 does not display the correct version information Apr 10, 2020
@cstrat
Copy link

cstrat commented Apr 14, 2020

Yeah I noticed that too. Doesn't have the code-server version on display in there anymore.

@kylecarbs
Copy link
Member

Will fix! cc: @code-asher

@kylecarbs kylecarbs changed the title v3.1.0 does not display the correct version information Version information is not displayed in About pane Apr 14, 2020
@code-asher
Copy link
Member

True, that's just the VS Code about panel so it only displays the VS Code version. Should we insert the code-server version into there again? I was trying to reduce patching that didn't seem necessary.

@kylecarbs
Copy link
Member

I think it'd be a good user experience, primarily because we'll show updates through that pane.

@Merith-TK
Copy link
Contributor Author

Merith-TK commented Apr 14, 2020 via email

@nhooyr nhooyr self-assigned this Apr 17, 2020
@nhooyr nhooyr added the bug Something isn't working label Apr 17, 2020
nhooyr added a commit that referenced this issue May 15, 2020
@nhooyr nhooyr closed this as completed in 40778b1 May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants