-
Notifications
You must be signed in to change notification settings - Fork 5.9k
/ssh endpoint should be disabled by default #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We might remove the SSH endpoint. Initially, it was added to do port-forwarding and a buncha other things, but isn't really needed anymore. |
a better idea, dont remove it, leave it there, but make it so it is disabled by default. because i can see a use. Like you have a server in which a few people need to access and you dont trust them with the user password (in fear they may attempt to and add documentation on the things existence. |
@Merith-TK There are plenty of ways to accomplish this without building in an SSH server. For example, you can load up a docker container and mount the workspace volume in it and give SSH access to that container. Maintaining an SSH server inside another application is a security nightmare especially given better alternatives exist. |
This comment has been minimized.
This comment has been minimized.
@jrebey We're going to just remove it. A docker container dependency isn't something we want users to think about. |
also, the changelogs on the release page do not state there is an ssh server, to begin with, and I think it is a decent security issue, because there may be people who don't use ssh for reasons or people who hold a STRICT ssh policy and this is just an ssh server without any user configurability by the looks of it, and it is enabled by default.
The text was updated successfully, but these errors were encountered: