Skip to content

Add favicon to binary #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nol166 opened this issue Mar 8, 2019 · 3 comments
Closed

Add favicon to binary #147

nol166 opened this issue Mar 8, 2019 · 3 comments
Labels
enhancement Some improvement that isn't a feature

Comments

@nol166
Copy link
Contributor

nol166 commented Mar 8, 2019

For ChromeOS users, it would be neat to have a favicon for the binary so when it's pinned to the taskbar it is easily distinguishable.
@nol166 nol166 added the enhancement Some improvement that isn't a feature label Mar 8, 2019
@codehz
Copy link

codehz commented Mar 16, 2019

I think it is better to implement it as PWA: just add a manifest.json and a simple ServiceWorker

@NGTmeaty
Copy link
Contributor

Active issue at #154 probably should close this?

@nol166
Copy link
Contributor Author

nol166 commented Mar 19, 2019

@NGTmeaty closing

@nol166 nol166 closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NGTmeaty @nol166 @codehz