Slashes in folder param become escaped

[Merith-TK]

Version: 1.41.1
Commit: f51e045cd5483561afc07694f39307fb673b6d1d
Date: 2020-01-17T22:58:55.612Z
Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36
Code Server Version: 2.1698-vsc1.41.1

• OS Version: archlinux

Description

When changing directories, it becomes
https://code.example.com/?folder=vscode-remote%3A%2F%2Fcode.example.com%2Fhome%2Fdeveloper%2FWorkspace%2FDND
instead of `https://code.example.com/?folder=/home/developer/Workspace/

Steps to Reproduce

1. open folder as default (accessible at https://example.com/)
2. CTRL+k and CTRL+O and open a different folder
3. check url

[Merith-TK]

yes i know the name of the issue is horrible, my words have been failing me today

[nhooyr]

Fixed :)

Thanks for reporting, I confirmed this.

[Merith-TK]

Yeah, also whats with the ?folder=vscode-remote%3A%2F%2Fcode.example.com%2F instead of ?folder=/

I dont understand why it does this?

[nhooyr]

Not sure either. cc @code-asher.

[code-asher]

I'm not certain, that just seems to be what VS Code 1.41.1 is doing now.

[code-asher]

To clarify, if you click file > open that's what VS Code puts in the URL, so I updated our server code to match.

[Merith-TK]

i think it may be because of the implementation?
This suggests that code-server uses a varient of the vscode-remote extension and wasnt properly modifed

[code-asher]

Internally VS Code refers to remote files with the vscode-remote:// scheme. In our case the remote provider is code-server but that doesn't change the scheme that VS Code uses. We could change it (and we used to) but there didn't seem any benefit in the added patching it required.

[Merith-TK]

Ah, alright then,

[coadler]

Aren't slashes supposed to be URL encoded in query strings?

[nhooyr]

It's optional.

package main

import (
	"fmt"
	"net/url"
)

func main() {
	u, _ := url.Parse("localhost:8080/?meow=bar/foo&big=coadler/asher")
	fmt.Println(u.Query())
}

Prints:

map[big:[coadler/asher] meow:[bar/foo]]

[coadler]

That's true it parses, but there'd be no way to construct the same thing on the way out

package main

import (
	"fmt"
	"net/url"
)

func main() {
	u, err := url.ParseQuery("meow=bar/foo&big=coadler/asher")
	if err != nil {
		panic(err)
	}
	
	fmt.Println(u)
	fmt.Println(u.Encode())
}

map[big:[coadler/asher] meow:[bar/foo]]
big=coadler%2Fasher&meow=bar%2Ffoo

https://tools.ietf.org/html/rfc2396#section-3.4 seems to indicate slashes are reserved within query strings

The documentation for ParseQuery says that it expects a URL-encoded query string but seems to work fine if it doesn't
https://golang.org/src/net/url/url.go?s=25201:25246#L859