Skip to content

Fix Docker image issues regarding UID/GIDs #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhooyr opened this issue Jan 28, 2020 · 5 comments
Closed

Fix Docker image issues regarding UID/GIDs #1307

nhooyr opened this issue Jan 28, 2020 · 5 comments
Assignees
@nhooyr
Labels
enhancement Some improvement that isn't a feature

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Jan 28, 2020

No description provided.

@nhooyr nhooyr added the enhancement Some improvement that isn't a feature label Jan 28, 2020
@nhooyr nhooyr self-assigned this Jan 28, 2020
This was referenced Jan 28, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@andylow
Copy link

andylow commented Mar 16, 2020

Hope this fix can be release asap :)

@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 16, 2020

This is done actually, forgot to close 😉

@nhooyr nhooyr closed this as completed Mar 16, 2020
@andylow
Copy link

andylow commented Mar 16, 2020

Wondering actually what fixes have been done? Any documentation to refer?
Because I use the latest docker image, still having the same permission issue with different uid/gid.

@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 17, 2020

We should update the README.md to include the flags to forward uid/gid.

See https://github.com/cdr/code-server/blob/89d78a592161ee6d6e6a12c9ee9fe1c564fc16e4/ci/release-image/Dockerfile

fixuid will adjust all files in the container to whatever UID/GID the image was ran with so there should be no issues as long as you are running it with the right uid/gid but I'd imagine many users are just using the default which is uid 1000.

@nhooyr nhooyr reopened this Mar 17, 2020
@nhooyr nhooyr mentioned this issue Mar 17, 2020
Closed
@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 17, 2020

See #1425

@nhooyr nhooyr closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhooyr nhooyr

Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andylow @nhooyr