Search in folder stopped working

[elgandoz]

• code-server version: 2.1662-vsc1.39.2
• OS Version: Centos/RHEL 7

Description

Searching a string in files, in a non-ignored folder, doesn't return any result, regardless of settings or type.
It looks somehow a regression from #438.

Reverting to 2.1650-vsc1.39.2, using the exact same configuration, works as expected.
I also tried to remove the configuration (thus starting with a fresh one) to make sure the issue doesn't sit there, but I get the same behavior.

I didn't try on version 2.1655-vsc1.39.2 (yet).

Steps to Reproduce

1. In the file explorer, right click on a folder > Find in Folder...
2. Type a string expected to be found and hit enter
3. The result is empty, even if you extend the search to all files

[code-asher]

Thanks for finding this!

[elgandoz]

Thanks for fixing it!

[roflcoopter]

@code-asher This issue seems to be again present in the latest release.
reverting back to tag 2.1697-vsc1.39.2 makes Find in Folder work again.

[muhammadnscorp]

@code-asher Find in Folder not working in
Version: 1.41.1
Code Server Version: 2.1698-vsc1.41.1

[nhooyr]

Is there an error?

[kylecarbs]

It's working for me on 2.1698-vsc1.41.1.

[muhammadnscorp]

[muhammadnscorp]

Its working on HTTPS but not on HTTP. Dont know if that is an intended behavior, if that is then its working fine.

[kylecarbs]

Did you remove /tmp/code-server?

On launch, code-server unpacks rg into that dir.

[muhammadnscorp]

I tried that and it's working now. thanks @kylecarbs

[roflcoopter]

This does not work still. Find in folder only applies to files that are open in the editor.
I am on the latest build from docker. No error is being printed

[kylecarbs]

@roflcoopter does /tmp/code-server/rg exist on your machine?

[roflcoopter]

Yes it's there

root@67ec5bfc0290:/tmp/code-server# ls
rg
root@67ec5bfc0290:/tmp/code-server#

[kylecarbs]

@roflcoopter is it executable? I'm not sure how you'd be unable to search in folders without an error appearing 🤔

[nhooyr]

He also said it only works on open files which is interesting.

[roflcoopter]

Yes it is executable. I have seen this issue mentioned in the vscode repo, I'm gonna try to setup a fresh install and see if that works.

[kylecarbs]

That'd be great!

[roflcoopter]

Got some time to test this out.
I created a new container based off of the official codercom/code-server:latest, all default settings.
I created som files and tried to search, but the results only show up if i have the files opened in the editor still. This is what the trace log says, not sure if it helps.

[2020-02-23 19:48:25.217] [remoteagent] [trace] telemetry/searchResultsShown {"properties":{"options.wordSeparators":"`~!@#$%^&*()-=+[{]}\\|;:'\",.<>/?","scheme":"file","common.machineId":"redacted","sessionID":"redacted","commitHash":"f51e045cd5483561afc07694f39307fb673b6d1d","version":"2.1698-vsc1.41.1","common.platformVersion":"4.15.0","common.platform":"Linux","common.nodePlatform":"linux","common.nodeArch":"x64","common.product":"code-server","timestamp":"2020-02-23T19:48:25.217Z"},"measurements":{"count":0,"fileCount":0,"options.isRegExp":0,"options.isCaseSensitive":0,"options.isWordMatch":0,"duration":1,"searchOnTypeEnabled":1,"common.timesincesessionstart":145377,"common.sequence":68}}
[2020-02-23 19:48:25.239] [remoteagent] [trace] telemetry/searchResultsShown {"count":0,"fileCount":0,"options":{"isRegExp":false,"isCaseSensitive":false,"isWordMatch":false,"wordSeparators":"`~!@#$%^&*()-=+[{]}\\|;:'\",.<>/?"},"duration":1,"scheme":"file","searchOnTypeEnabled":true}
[2020-02-23 19:48:25.240] [remoteagent] [trace] telemetry/searchResultsFinished {"properties":{"common.machineId":"redacted","sessionID":"redacted","commitHash":"f51e045cd5483561afc07694f39307fb673b6d1d","version":"2.1698-vsc1.41.1","common.platformVersion":"4.15.0","common.platform":"Linux","common.nodePlatform":"linux","common.nodeArch":"x64","common.product":"code-server","timestamp":"2020-02-23T19:48:25.239Z"},"measurements":{"duration":1,"common.timesincesessionstart":145399,"common.sequence":69}}
[2020-02-23 19:48:25.243] [remoteagent] [trace] telemetry/searchResultsFinished {"duration":1}
[2020-02-23 19:48:25.244] [remoteagent] [trace] telemetry/searchResultsFirstRender {"properties":{"common.machineId":"redacted","sessionID":"redacted","commitHash":"f51e045cd5483561afc07694f39307fb673b6d1d","version":"2.1698-vsc1.41.1","common.platformVersion":"4.15.0","common.platform":"Linux","common.nodePlatform":"linux","common.nodeArch":"x64","common.product":"code-server","timestamp":"2020-02-23T19:48:25.243Z"},"measurements":{"duration":1,"common.timesincesessionstart":145403,"common.sequence":70}}
[2020-02-23 19:48:25.246] [remoteagent] [trace] telemetry/searchResultsFirstRender {"duration":1}

[code-asher]

I'm curious if 3.0.0 fixes this. We have a 3.0.0 Docker tag if you have some time to check it out. I just ran it and was able to search without any issues (on both HTTP and HTTPS).

[roflcoopter]

I'm curious if 3.0.0 fixes this. We have a 3.0.0 Docker tag if you have some time to check it out. I just ran it and was able to search without any issues (on both HTTP and HTTPS).

Sorry for the late reply, but yes 3.0.0 seems to fix it! I Haven't move over to it just yet i just did a quick smoke test. You can close this for now and I'll report back if it doesnt work in the future