Skip to content

Commit d4f7328

Browse files
nhooyrkylecarbs
authored andcommitted
Fix build and Dockerfile issues (#176)
* build: fix yarn corruption issues Closes #100 Thanks @zerdos * Dockerfile: add default Entrypoint and mount data dir Closes #170 Closes #78 Thanks @ay-b
1 parent 2bf6051 commit d4f7328

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

Dockerfile

+2-1
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,6 @@ RUN apt-get install -y locales && \
2828
# We unfortunately cannot use update-locale because docker will not use the env variables
2929
# configured in /etc/default/locale so we need to set it manually.
3030
ENV LANG=en_US.UTF-8
31-
# Unfortunately `.` does not work with code-server.
31+
ENTRYPOINT code-server
32+
# Unfortunately `.` does not work with code-server so we use shell form.
3233
CMD code-server $PWD

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
Try it out:
1111
```bash
12-
docker run -p 127.0.0.1:8443:8443 -v "${PWD}:/root/project" codercom/code-server code-server --allow-http --no-auth
12+
docker run -p 127.0.0.1:8443:8443 -v "${PWD}:/root/project" -v ~/.code-server:/root/.code-server codercom/code-server --allow-http --no-auth
1313
```
1414

1515
- Code on your Chromebook, tablet, and laptop with a consistent dev environment.

scripts/install-packages.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,7 @@ const handlePackages = async (dir: string): Promise<void> => {
4141
const pkgDir = join(dir, pkg);
4242
const pkgJsonPath = join(pkgDir, "package.json");
4343
if (existsSync(pkgJsonPath)) {
44-
const ip = doInstall(pkg, pkgDir);
45-
if (os.platform() === "win32") {
46-
await ip;
47-
}
44+
const ip = await doInstall(pkg, pkgDir);
4845
}
4946
}
5047
};

0 commit comments

Comments
 (0)