Skip to content

Commit 39b7aa9

Browse files
committed
Remove keytar during cross-compile
It fails to compile which fails CI. In the past we were just ignoring the error. Since it will be removed shortly and it is already missing (so not a regression), just skip it entirely.
1 parent acc50a5 commit 39b7aa9

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/release.yaml

+6-1
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,11 @@ jobs:
150150
- name: Decompress npm package
151151
run: tar -xzf package.tar.gz
152152

153+
# Keytar makes npm install fail. It is going away soon so it might not be
154+
# worth the effort to figure it out.
155+
- name: Remove keytar
156+
run: cd lib/vscode && npm remove keytar
157+
153158
# NOTE@jsjoeio - npm fails here
154159
# so use yarn
155160
- name: Build standalone release
@@ -161,7 +166,7 @@ jobs:
161166
tar -xf node-${NODE_VERSION}-linux-${NPM_CONFIG_ARCH}.tar.xz node-${NODE_VERSION}-linux-${NPM_CONFIG_ARCH}/bin/node --strip-components=2
162167
mv ./node ./release-standalone/lib/node
163168
164-
# NOTE@jsjoeio - we do this so we can strip out the v
169+
# NOTE@jsjoeio - we do this so we can strip cut the v
165170
# i.e. v4.9.1 -> 4.9.1
166171
- name: Get and set VERSION
167172
run: |

0 commit comments

Comments
 (0)