11import { logger } from "@coder/logger"
22import * as http from "http"
3- import { AddressInfo } from "net"
43import * as path from "path"
4+ import { ensureAddress } from "../../../src/node/app"
55import { SettingsProvider , UpdateSettings } from "../../../src/node/settings"
66import { LatestResponse , UpdateProvider } from "../../../src/node/update"
7- import { clean , isAddressInfo , mockLogger , tmpdir } from "../../utils/helpers"
7+ import { clean , mockLogger , tmpdir } from "../../utils/helpers"
88
99describe ( "update" , ( ) => {
1010 let version = "1.0.0"
@@ -79,14 +79,14 @@ describe("update", () => {
7979 }
8080
8181 let _provider : UpdateProvider | undefined
82- let _address : string | AddressInfo | null
8382 const provider = ( ) : UpdateProvider => {
8483 if ( ! _provider ) {
8584 throw new Error ( "Update provider has not been created" )
8685 }
8786 return _provider
8887 }
8988
89+ let address = new URL ( "http://localhost" )
9090 beforeAll ( async ( ) => {
9191 mockLogger ( )
9292
@@ -105,12 +105,13 @@ describe("update", () => {
105105 } )
106106 } )
107107
108- _address = server . address ( )
109- if ( ! isAddressInfo ( _address ) ) {
110- throw new Error ( "unexpected address " )
108+ const addr = ensureAddress ( server , "http" )
109+ if ( typeof addr === "string" ) {
110+ throw new Error ( "unable to run update tests with unix sockets " )
111111 }
112-
113- _provider = new UpdateProvider ( `http://${ _address ?. address } ${ _address ?. port } , _settings )
112+ address = addr
113+ address . pathname = "/latest"
114+ _provider = new UpdateProvider ( address . toString ( ) , _settings )
114115 } )
115116
116117 afterAll ( ( ) => {
@@ -220,59 +221,51 @@ describe("update", () => {
220221 } )
221222
222223 it ( "should reject if response has status code 500" , async ( ) => {
223- if ( isAddressInfo ( _address ) ) {
224- const mockURL = `http://${ _address . address } ${ _address . port }
225- const provider = new UpdateProvider ( mockURL , settings ( ) )
226- const update = await provider . getUpdate ( true )
227-
228- expect ( update . version ) . toBe ( "unknown" )
229- expect ( logger . error ) . toHaveBeenCalled ( )
230- expect ( logger . error ) . toHaveBeenCalledWith ( "Failed to get latest version" , {
231- identifier : "error" ,
232- value : `${ mockURL } ,
233- } )
234- }
224+ address . pathname = "/reject-status-code"
225+ const provider = new UpdateProvider ( address . toString ( ) , settings ( ) )
226+ const update = await provider . getUpdate ( true )
227+
228+ expect ( update . version ) . toBe ( "unknown" )
229+ expect ( logger . error ) . toHaveBeenCalled ( )
230+ expect ( logger . error ) . toHaveBeenCalledWith ( "Failed to get latest version" , {
231+ identifier : "error" ,
232+ value : `${ address . toString ( ) } ,
233+ } )
235234 } )
236235
237236 it ( "should reject if no location header provided" , async ( ) => {
238- if ( isAddressInfo ( _address ) ) {
239- const mockURL = `http://${ _address . address } ${ _address . port }
240- const provider = new UpdateProvider ( mockURL , settings ( ) )
241- const update = await provider . getUpdate ( true )
242-
243- expect ( update . version ) . toBe ( "unknown" )
244- expect ( logger . error ) . toHaveBeenCalled ( )
245- expect ( logger . error ) . toHaveBeenCalledWith ( "Failed to get latest version" , {
246- identifier : "error" ,
247- value : `received redirect with no location header` ,
248- } )
249- }
237+ address . pathname = "/no-location-header"
238+ const provider = new UpdateProvider ( address . toString ( ) , settings ( ) )
239+ const update = await provider . getUpdate ( true )
240+
241+ expect ( update . version ) . toBe ( "unknown" )
242+ expect ( logger . error ) . toHaveBeenCalled ( )
243+ expect ( logger . error ) . toHaveBeenCalledWith ( "Failed to get latest version" , {
244+ identifier : "error" ,
245+ value : `received redirect with no location header` ,
246+ } )
250247 } )
251248
252249 it ( "should resolve the request with response.headers.location" , async ( ) => {
253250 version = "4.1.1"
254- if ( isAddressInfo ( _address ) ) {
255- const mockURL = `http://${ _address . address } ${ _address . port }
256- const provider = new UpdateProvider ( mockURL , settings ( ) )
257- const update = await provider . getUpdate ( true )
251+ address . pathname = "/with-location-header"
252+ const provider = new UpdateProvider ( address . toString ( ) , settings ( ) )
253+ const update = await provider . getUpdate ( true )
258254
259- expect ( logger . error ) . not . toHaveBeenCalled ( )
260- expect ( update . version ) . toBe ( "4.1.1" )
261- }
255+ expect ( logger . error ) . not . toHaveBeenCalled ( )
256+ expect ( update . version ) . toBe ( "4.1.1" )
262257 } )
263258
264259 it ( "should reject if more than 10 redirects" , async ( ) => {
265- if ( isAddressInfo ( _address ) ) {
266- const mockURL = `http://${ _address . address } ${ _address . port }
267- const provider = new UpdateProvider ( mockURL , settings ( ) )
268- const update = await provider . getUpdate ( true )
269-
270- expect ( update . version ) . toBe ( "unknown" )
271- expect ( logger . error ) . toHaveBeenCalled ( )
272- expect ( logger . error ) . toHaveBeenCalledWith ( "Failed to get latest version" , {
273- identifier : "error" ,
274- value : `reached max redirects` ,
275- } )
276- }
260+ address . pathname = "/redirect/11"
261+ const provider = new UpdateProvider ( address . toString ( ) , settings ( ) )
262+ const update = await provider . getUpdate ( true )
263+
264+ expect ( update . version ) . toBe ( "unknown" )
265+ expect ( logger . error ) . toHaveBeenCalled ( )
266+ expect ( logger . error ) . toHaveBeenCalledWith ( "Failed to get latest version" , {
267+ identifier : "error" ,
268+ value : `reached max redirects` ,
269+ } )
277270 } )
278271} )
0 commit comments