Fix being unable to use [::] for the host

code-asher · code-asher · commit 11eaf0b470c9 · 2020-09-30T12:49:36.000-05:00
Fixes #1582.
diff --git a/src/node/http.ts b/src/node/http.ts
@@ -584,8 +584,11 @@ export class HttpServer {
         const onListen = (): void => resolve(this.address())
         if (this.options.socket) {
           this.server.listen(this.options.socket, onListen)
+        } else if (this.options.host) {
+          // [] is the correct format when using :: but Node errors with them.
+          this.server.listen(this.options.port, this.options.host.replace(/^\[|\]$/g, ""), onListen)
         } else {
-          this.server.listen(this.options.port, this.options.host, onListen)
+          this.server.listen(this.options.port, onListen)
         }
       })
     }

Original file line number	Diff line number	Diff line change
`@@ -584,8 +584,11 @@ export class HttpServer {`
`584`	`584`	`const onListen = (): void => resolve(this.address())`
`585`	`585`	`if (this.options.socket) {`
`586`	`586`	`this.server.listen(this.options.socket, onListen)`
	`587`	`+ } else if (this.options.host) {`
	`588`	`+ // [] is the correct format when using :: but Node errors with them.`
	`589`	`+ this.server.listen(this.options.port, this.options.host.replace(/^\[\|\]$/g, ""), onListen)`
`587`	`590`	`} else {`
`588`		`- this.server.listen(this.options.port, this.options.host, onListen)`
	`591`	`+ this.server.listen(this.options.port, onListen)`
`589`	`592`	`}`
`590`	`593`	`})`
`591`	`594`	`}`