Skip to content

add warning for --link deprecation #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2022
Merged

add warning for --link deprecation #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb78ca
add warning for --link deprecation
bpmct Nov 29, 2021
22d6757
change wording
bpmct Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/cmd/bind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ func (c *bindCmd) Run(fl *pflag.FlagSet) {
}
}

flog.Info("code-server --link is deprecated. While the servers will remain online,")
flog.Info("we are not releasing new features or bugfixes. A future code-server")
flog.Info("release will include a v2 with new features. If you would")
flog.Info("like early access, reach out on https://cdr.co/join-community")
flog.Info("")
Comment on lines +116 to +120
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure if this was the best way to do multi-line messages with flog. I also noticed there is no "warning" level for logs (see coder/flog#1)



flog.Info("Proxying code-server, you can access your IDE at %v", url)

proxy()
Expand Down