Skip to content

Use GitHub actions to upload release artifacts #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

oxy
Copy link
Contributor

@oxy oxy commented Mar 17, 2021

Whenever a GH release is created/published, this should automatically build cloud-agent and upload the binaries for linux/macOS amd64/arm64. These are the platforms we currently build for on code-server with the exception of macos-arm64, which I'm currently investigating.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 14, 2021

Hey @oxy - sorry this took so long to address. I spoke to Jon A. about this. He said it mostly looks good.

Last thing to do, look over the workflow they use in m and make sure this new workflow isn't missing anything, specifically looking at signing the macOS binaries so that they work properly.

@sreya
Copy link
Contributor

sreya commented Apr 14, 2021

@jsjoeio I don't believe @oxy is going to have access to that repo. It will be up to us to ensure that we add in the bits that we were using internally.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 14, 2021

Ah, good point. Okay, I'll take a look then!

@oxy
Copy link
Contributor Author

oxy commented Apr 16, 2021

Oh - signing could be a problem; right now it just produces unsigned builds, and since I don't have access to secrets for this repo, or any Apple devices to test on/work with, I'm not sure how to handle signing.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 16, 2021

Oh - signing could be a problem; right now it just produces unsigned builds, and since I don't have access to secrets for this repo, or any Apple devices to test on/work with, I'm not sure how to handle signing

No worries at all. I have Apple Devices and access to secrets. I'm going to take a look at this next week and should be able to push the necessary changes

@jsjoeio jsjoeio added the enhancement New feature or request label Apr 28, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 28, 2021

Spoke to @sreya and he said we can skip the Apple signing for now.

@oxy
Copy link
Contributor Author

oxy commented Apr 29, 2021

I'll edit this to use gh instead of hub today/tomorrow; should be ready then.

@oxy oxy marked this pull request as draft April 29, 2021 01:17
@oxy oxy force-pushed the gh-actions-final branch from f676e44 to 1a2e7d5 Compare April 29, 2021 16:48
@oxy oxy marked this pull request as ready for review April 29, 2021 16:50
@oxy
Copy link
Contributor Author

oxy commented Apr 29, 2021

Cleaned up to use a matrix + to use gh instead of hub and it still works! 🎉
https://github.com/oxy/cloud-agent/releases/tag/v0.2.5.2 (ignore the version)

Hopefully should be good for another review @jsjoeio.

@oxy oxy requested a review from jsjoeio April 29, 2021 16:51
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really clean and way easy to read! Nice work! 🙌

@oxy
Copy link
Contributor Author

oxy commented Apr 29, 2021

I think either you or sreya would have to merge it in - I don't have write access 😅

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 29, 2021

Ah gotcha. Okay I'll merge 🤞

@jsjoeio jsjoeio merged commit d2451d5 into coder:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants