fix: wrap ERROR and WARN logging in vim.schedule to prevent fast event context errors #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t context errors Fixes issue where closing and reopening MacBook would trigger TCP connection errors that call logger.error() from timer callbacks (fast event context), causing "nvim_echo must not be called in a fast event context" errors. Changes: - Wrap vim.notify calls for ERROR and WARN levels in vim.schedule() - Add comprehensive test suite for logger fast event context safety - All logging levels now safely callable from any event context Fixes #51 Change-Id: I9791d9e788745225aeac7c19c6c33562f95f086b Signed-off-by: Thomas Kosiewski <[email protected]>
Fixes test failures caused by missing vim.schedule function in the local vim mock used by selection_test.lua. The logger now requires vim.schedule to be available for all logging levels. Change-Id: Iec504a23187522a4f7968ec88d85476719a177d4 Signed-off-by: Thomas Kosiewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #51 - Prevents "nvim_echo must not be called in a fast event context" errors that occur when TCP connection errors are triggered from timer callbacks (e.g., after laptop sleep/wake).
vim.notifycalls for ERROR and WARN levels invim.schedule()Changes
lua/claudecode/logger.luato wrap ERROR and WARNvim.notifycalls invim.schedule()tests/unit/logger_spec.luawith comprehensive test coverage for fast event context safetyThe fix specifically addresses the error stack trace from the issue where
logger.error()was called fromserver/tcp.lua:254within a timer callback, which is a fast event context where direct vim API calls are not allowed.